Changes

Summary

  1. Fixes #5343 (details)
  2. Intermediate commit (details)
  3. Removed special FindBlockArgumentAssignmet visitor (details)
  4. Rewrite of many #basicCheck: to #check:forCritiquesDo: (details)
  5. Moved and renamed Superclass for many of the rule tests (details)
  6. cleaning up (details)
  7. fixed error wrt. ClassVariables (details)
  8. explained why the hack is legit (details)
  9. Kickstarting the integration engine (details)
Commit 7818c597fce7388e0eb2f5c57242fb3e1ea1bccb by kasper.osterbye
Fixes #5343
**Not done yet !!**. I have updated/checked all the
`check:forCritiquesDo:` methods though
The file was addedsrc/GeneralRules-Tests/RBTempVarOverridesInstVarRuleTest.class.st
The file was modifiedsrc/Renraku/ReAbstractRule.class.st (diff)
The file was modifiedsrc/GeneralRules/RBTempVarOverridesInstVarRule.class.st (diff)
The file was modifiedsrc/GeneralRules/RBMultiplePeriodsTerminatingStatementRule.class.st (diff)
The file was modifiedsrc/GeneralRules/RBSentNotImplementedRule.class.st (diff)
The file was addedsrc/GeneralRules-Tests/RBSentNotImplementedRuleTest.class.st
The file was addedsrc/GeneralRules-Tests/RBMultiplePeriodsTerminatingStatementRuleTest.class.st
The file was addedsrc/GeneralRules-Tests/RBMethodSourceContainsLinefeedsRuleTest.class.st
The file was modifiedsrc/Renraku/ReNoPrintStringInPrintOnRule.class.st (diff)
The file was modifiedsrc/Renraku/ReReturnMethodRule.class.st (diff)
The file was addedsrc/GeneralRules-Tests/RBAssignmentOnBlockArgumentRuleTest.class.st
The file was modifiedsrc/Renraku/ReThemeAccess.class.st (diff)
The file was modifiedsrc/GeneralRules/RBGlobalVariablesUsage.class.st (diff)
The file was modifiedsrc/GeneralRules/RBMethodSourceContainsLinefeedsRule.class.st (diff)
The file was modifiedsrc/GeneralRules/RBAssignmentOnBlockArgumentRule.class.st (diff)
The file was addedsrc/GeneralRules-Tests/RBGlobalVariablesUsageTest.class.st
The file was modifiedsrc/Renraku-Test/ReNoPrintStringInPrintOnRuleTest.class.st (diff)
The file was modifiedsrc/Renraku/ReNoNilAssignationInInitializeRule.class.st (diff)
The file was modifiedsrc/GeneralRules/RBSelfSentNotImplementedRule.class.st (diff)
Commit 86dbff14cb1beb3121bed0ad74ddd1728e8693c0 by kasper.osterbye
Removed special FindBlockArgumentAssignmet visitor
The file was modifiedsrc/GeneralRules/RBAssignmentOnBlockArgumentRule.class.st (diff)
The file was removedsrc/AST-Core/RBFindBlockArgumentAssignment.class.st
Commit 052ffe4c447be695ee0452737a76964dfb8cc0ac by kasper.osterbye
Rewrite of many #basicCheck: to #check:forCritiquesDo:
#basicCheck: is a boolean check, whereas #check:forCritiquesDo: can
return where in the code the problem is.
The file was modifiedsrc/GeneralRules-Tests/RBMethodSourceContainsLinefeedsRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBGlobalVariablesUsageTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBRefersToClassRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules/RBUsesTrueRule.class.st (diff)
The file was modifiedsrc/GeneralRules/RBUncommonMessageSendRule.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBMultiplePeriodsTerminatingStatementRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBTempVarOverridesInstVarRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules/RBAssignmentOnBlockArgumentRule.class.st (diff)
The file was removedsrc/GeneralRules-Tests/RBAbstractMockToTestRefersToClassRule.class.st
The file was modifiedsrc/Renraku/ReAbstractRule.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBSentNotImplementedRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules/RBMethodSourceContainsLinefeedsRule.class.st (diff)
The file was modifiedsrc/GeneralRules/RBSelfSentNotImplementedRule.class.st (diff)
The file was modifiedsrc/GeneralRules/RBGlobalVariablesUsage.class.st (diff)
The file was modifiedsrc/Renraku/ReNoNilAssignationInInitializeRule.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBAssignmentOnBlockArgumentRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules/RBRefersToClassRule.class.st (diff)
The file was addedsrc/GeneralRules-Tests/RBUsesTrueRuleTest.class.st
The file was modifiedsrc/GeneralRules/RBSentNotImplementedRule.class.st (diff)
The file was modifiedsrc/Renraku/ReThemeAccess.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBSelfSentNotImplementedRuleTest.class.st (diff)
The file was addedsrc/GeneralRules-Tests/RBUncommonMessageSendRuleTest.class.st
The file was modifiedsrc/Renraku/ReNoPrintStringInPrintOnRule.class.st (diff)
Commit d1abbf0cd45a77a3d47a3eeed1278c59b18403d1 by kasper.osterbye
Moved and renamed Superclass for many of the rule tests
The file was modifiedsrc/GeneralRules-Tests/RBTempVarOverridesInstVarRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBMethodSourceContainsLinefeedsRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBUsesTrueRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBUncommonMessageSendRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBSentNotImplementedRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBRefersToClassRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBSelfSentNotImplementedRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBAssignmentOnBlockArgumentRuleTest.class.st (diff)
The file was addedsrc/GeneralRules-Tests/RBAbstractRuleTestCase.class.st
The file was modifiedsrc/GeneralRules-Tests/RBGlobalVariablesUsageTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBMultiplePeriodsTerminatingStatementRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBGlobalVariablesUsageTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBUncommonMessageSendRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBSentNotImplementedRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBRefersToClassRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBUsesTrueRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBAbstractRuleTestCase.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBSelfSentNotImplementedRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBTempVarOverridesInstVarRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBAssignmentOnBlockArgumentRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBMultiplePeriodsTerminatingStatementRuleTest.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/RBMethodSourceContainsLinefeedsRuleTest.class.st (diff)
Commit 71071485a877d9b8175210bac8587a3b003a3c58 by kasper.osterbye
fixed error wrt. ClassVariables
I had not expected #isGlobal to return true for class variables. Alas, I
stand corrected
The file was modifiedsrc/GeneralRules/RBMethodSourceContainsLinefeedsRule.class.st (diff)
The file was modifiedsrc/GeneralRules/RBGlobalVariablesUsage.class.st (diff)
Commit ce8b0fbd4f7938a8c2ab185a8880dec9f7c793e6 by kasper.osterbye
explained why the hack is legit
The file was modifiedsrc/GeneralRules/RBGlobalVariablesUsage.class.st (diff)
Commit ea302f6310241b862c2ce5f2e531e35e21b25da0 by kasper.osterbye
Kickstarting the integration engine
And classified some methods
The file was modifiedsrc/GeneralRules-Tests/RBAbstractRuleTestCase.class.st (diff)