FailedChanges

Summary

  1. 21368 Integrate FileAttributesPlugin (details)
  2. Reset file mode masks on startup (details)
  3. 21368 Initialise File in PharoBootstrapInitialization (details)
  4. Fixes for Windows specific code introduced by latest refactoring (details)
  5. The VM will return Squeak times instead of Unix times (details)
  6. File attributes #uid, #gid and #deviceId (details)
  7. File attribute #inode (details)
  8. 21368 - Remove WindowsStore class>>useFilePlugin (details)
  9. 21368: DiskFileAttributesTests>>setUp call super setUp (details)
  10. 21368: Add MemoryStore missing attributes (details)
  11. 21368 - Refactor to undo adding FileSystem dependency to Files (details)
  12. 21368 - redo DiskFileAttributesTests>>setUp (details)
  13. 21368 additional descriptions for FileSystemTest>>testFileNames (details)
  14. 21368: FileSystemTest>>testFileNames additional debug information (details)
  15. FileAttributesPlugin: Fix DiskStore>>isSymlink (was still using (details)
  16. FileAttributes: DiskDirectoryEntry>>isSymlink failed on Windows (details)
  17. FileAttributes: VM now flags when symlinks aren't supported (details)
  18. DiskStore>>nodesAt:do: prepare for FileAttributesPlugin 2.0.0 (details)
  19. FileAttributes: Use UTF8 file names with code points > 255 when testing (details)
  20. 21368: Fix and unify UTF8 file encoding on Windows (details)
  21. 21368: tidy up primitive error handling (details)
  22. 21368: Tidy up FileSystem code (details)
  23. 21368: More tidying up (details)
  24. FileAttributesPlugin: Add ability to set file ownership and permissions (details)
  25. FileAttributes: Platform path name conversion (details)
  26. BreadthFirstGuide>>visitNextEntry: check that file exists (details)
  27. Push DiskDirectoryEntry>>exists up to FileSystemDirectoryEntry so that (details)
  28. WindowsStore>>directoryAt:nodesDo: & (details)
  29. Add BOOTSTRAP_VMTARGET to bootstrap scripts (details)
  30. FileSystem>>move:to: do nothing if the source and destination are the (details)
  31. envvars.sh: check for unset variable (not empty) (details)
  32. Modify File Attributes to reflect updated windows attributes (details)
Commit 99972e661ce03a654dc0984be19561b5d1f8d581 by akgrant0710
21368 Integrate FileAttributesPlugin
Modify Files and FileSystem to use the enhanced functionality provided
by FileAttributesPlugin.
The file was modifiedsrc/FileSystem-Core/FileSystemStore.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/WindowsStore.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileSystem.class.st (diff)
The file was modifiedsrc/FileSystem-Memory/MemoryStore.class.st (diff)
The file was modifiedsrc/FileSystem-Tests-Core/AbstractEnumerationVisitorTest.class.st (diff)
The file was modifiedsrc/Files/File.class.st (diff)
The file was addedsrc/FileSystem-Tests-Attributes/DiskFileAttributesTests.class.st
The file was addedsrc/FileSystem-Core/FileAttributeNotSupported.class.st
The file was modifiedsrc/FileSystem-Tests-Core/FileReferenceTest.class.st (diff)
The file was modifiedsrc/FileSystem-Tests-Attributes/DiskFileAttributesTestsResources.class.st (diff)
The file was addedsrc/FileSystem-Core/DiskSymlinkDirectoryEntry.class.st
The file was addedsrc/FileSystem-Core/DiskDirectoryEntry.class.st
The file was modifiedsrc/FileSystem-Core/FileReference.class.st (diff)
The file was modifiedsrc/FileSystem-Core/AbstractFileReference.class.st (diff)
The file was addedsrc/FileSystem-Core/MemoryDirectoryEntry.class.st
The file was addedsrc/FileSystem-Tests-Attributes/FileAttributesPluginPrimsTests.class.st
The file was modifiedsrc/FileSystem-Tests-Attributes/FileReferenceAttributeTests.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileSystemDirectoryEntry.class.st (diff)
Commit df00ef8d780531c16c4b5bc323a54635086564d6 by akgrant0710
Reset file mode masks on startup
The file was modifiedsrc/Files/File.class.st (diff)
Commit ebc8ea4d4f33f93e340d2801efd36745eb8c5d2c by akgrant0710
21368 Initialise File in PharoBootstrapInitialization
class>>initializeFileSystem
File loads a number of constants from the VM along with keeping a
character encoder.
The file was modifiedsrc/PharoBootstrap-Initialization/PharoBootstrapInitialization.class.st (diff)
Commit 5cda1b47802e705515094179bdda334e3f57b41e by akgrant0710
Fixes for Windows specific code introduced by latest refactoring
The file was modifiedsrc/Files/File.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/WindowsStore.class.st (diff)
Commit c4617ab64048d58df71aa3b28f9dd89309a842c0 by akgrant0710
The VM will return Squeak times instead of Unix times
The file was modifiedsrc/Kernel/DateAndTime.class.st (diff)
The file was modifiedsrc/FileSystem-Core/DiskDirectoryEntry.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
Commit 990259870414ae7cca861941d03605cfea83b58a by akgrant0710
File attributes #uid, #gid and #deviceId
Lost during latest refactor
The file was modifiedsrc/FileSystem-Core/FileReference.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileSystem.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
Commit 501dce77634e2184b3b728f71ddc7f67ee2eb85f by akgrant0710
File attribute #inode
Lost during latest refactor
The file was modifiedsrc/FileSystem-Core/FileReference.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
Commit 2d90b5916e7cf54b98f6c3254d5bedc6ccb3fba1 by akgrant0710
21368 - Remove WindowsStore class>>useFilePlugin
This is a leftover from before the FilePluginPrims refactoring.
The file was modifiedsrc/FileSystem-Disk/WindowsStore.class.st (diff)
Commit ca38f5f853d3456f2aab47208169ccb7bb498851 by akgrant0710
21368: DiskFileAttributesTests>>setUp call super setUp
The file was modifiedsrc/FileSystem-Tests-Attributes/DiskFileAttributesTests.class.st (diff)
Commit 90999eade4b96e3070a568d5baf699f5490f4789 by akgrant0710
21368: Add MemoryStore missing attributes
#isReadable:, #isRegular:, #isWritable, #permissions:
The file was modifiedsrc/FileSystem-Memory/MemoryStore.class.st (diff)
Commit 29c181f5d4322c79542f0fe7fcb40ce081c59dff by akgrant0710
21368 - Refactor to undo adding FileSystem dependency to Files
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
The file was modifiedsrc/Files/File.class.st (diff)
The file was modifiedsrc/FileSystem-Memory/MemoryStore.class.st (diff)
The file was addedsrc/Files/IllegalFileName.class.st
The file was modifiedsrc/FileSystem-Tests-Attributes/DiskFileAttributesTests.class.st (diff)
The file was modifiedsrc/FileSystem-Tests-Attributes/FileAttributesPluginPrimsTests.class.st (diff)
Commit 5a73631027bc93c889f6d3e30b9115363fb6b397 by akgrant0710
21368 - redo DiskFileAttributesTests>>setUp
#setUp should call super setUp as the first message.
The file was modifiedsrc/FileSystem-Tests-Attributes/DiskFileAttributesTests.class.st (diff)
Commit 37e4f735d287fce537b9656da01c03cd9be9d728 by akgrant0710
21368 additional descriptions for FileSystemTest>>testFileNames
The file was modifiedsrc/FileSystem-Tests-Core/FileSystemTest.class.st (diff)
Commit d30afb8bdec78fb181395ed3404a4deaa4d1d2b3 by akgrant0710
21368: FileSystemTest>>testFileNames additional debug information
The file was modifiedsrc/FileSystem-Tests-Core/FileSystemTest.class.st (diff)
Commit 3f7faf3f99fca6ee8c689eda3357996203ad403c by akgrant0710
FileAttributesPlugin: Fix DiskStore>>isSymlink (was still using
FilePlugin), Remove platform hack in File class>>isSymlink:
The file was modifiedsrc/FileSystem-Disk/WindowsStore.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
The file was modifiedsrc/Files/File.class.st (diff)
Commit 3c080eae3f22841ba5c0e08457313aa3d18008ca by akgrant0710
FileAttributes: DiskDirectoryEntry>>isSymlink failed on Windows
Delegate the test to FileReference so that platform specific processing
is performed.
The file was modifiedsrc/FileSystem-Core/DiskDirectoryEntry.class.st (diff)
Commit 60515016fcbec9304351ea7c2f1f7d3109c3fe46 by akgrant0710
FileAttributes: VM now flags when symlinks aren't supported
The file was modifiedsrc/FileSystem-Core/DiskDirectoryEntry.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/WindowsStore.class.st (diff)
The file was modifiedsrc/Files/File.class.st (diff)
Commit ad66454c2e0c0ec68f820499a0408333d5c75d6a by akgrant0710
DiskStore>>nodesAt:do: prepare for FileAttributesPlugin 2.0.0
primitiveOpenDirectory returns the first entry in v2.0.0, which is
backward incompatible with v1.4.0.  #nodesAt:do: detects the return type
from the primitive and adjusts appropriately.
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
Commit 86d7b99775b24765ef717cde37252c27825713e8 by akgrant0710
FileAttributes: Use UTF8 file names with code points > 255 when testing
The file was modifiedsrc/FileSystem-Tests-Core/FileSystemTest.class.st (diff)
The file was modifiedsrc/FileSystem-Tests-Attributes/DiskFileAttributesTestsResources.class.st (diff)
Commit b4fb3efb4c315f401379b301efdae348436d538f by akgrant0710
21368: Fix and unify UTF8 file encoding on Windows
The file was modifiedsrc/Files/File.class.st (diff)
The file was modifiedsrc/FileSystem-Core/DiskDirectoryEntry.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
Commit 97e8e464cb949c6163e1c01ad0a69c8767444a8c by akgrant0710
21368: tidy up primitive error handling
- Move duplicated code to #signalError:for:
- Pass error information provided by the primitives when signalling.
The file was modifiedsrc/FileSystem-Tests-Attributes/FileAttributesPluginPrimsTests.class.st (diff)
The file was modifiedsrc/Files/File.class.st (diff)
Commit c19821400e00fef1ecbdfd1505c1e0dd4f4763ad by akgrant0710
21368: Tidy up FileSystem code
Remove some unecessary changes, which should also improve compatibility
with any other file system stores.
The file was modifiedsrc/FileSystem-Core/DiskDirectoryEntry.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileSystem.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileSystemStore.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
Commit 6f1d22a5d91550e2eda3ffce9ecddc63534d46d3 by akgrant0710
21368: More tidying up
Revert more changes to improve backward compatibility
The file was modifiedsrc/FileSystem-Core/FileSystemStore.class.st (diff)
The file was modifiedsrc/FileSystem-Memory/MemoryStore.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileSystem.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/WindowsStore.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileReference.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
Commit bedbadf6fff109ac967b75adb12f8b589a07333b by akgrant0710
FileAttributesPlugin: Add ability to set file ownership and permissions
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileReference.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileSystemDirectoryEntry.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileSystem.class.st (diff)
The file was modifiedsrc/FileSystem-Tests-Attributes/DiskFileAttributesTests.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileSystemPermission.class.st (diff)
The file was modifiedsrc/Files/File.class.st (diff)
Commit 5c43e10363cb765c8e68eb60665912c6ac330367 by akgrant0710
FileAttributes: Platform path name conversion
The file was modifiedsrc/Files/File.class.st (diff)
The file was modifiedsrc/FileSystem-Tests-Attributes/DiskFileAttributesTests.class.st (diff)
Commit de3a9a601dee1cb3d691918a85e8ee67562a9964 by akgrant0710
BreadthFirstGuide>>visitNextEntry: check that file exists
Previously a DirectoryEntry>>isFile would return true for a broken
symbolic link due to a bug that returned the link attributes instead of
the file attributes.  If the file doesn't exist, don't visit the file or
treat it as a directory.
The file was modifiedsrc/FileSystem-Core/BreadthFirstGuide.class.st (diff)
The file was modifiedsrc/FileSystem-Core/DiskDirectoryEntry.class.st (diff)
Commit dd466f7e4c5e3c595be7daecedfdd78e923c8280 by akgrant0710
Push DiskDirectoryEntry>>exists up to FileSystemDirectoryEntry so that
it is generally available.
The file was modifiedsrc/FileSystem-Core/DiskDirectoryEntry.class.st (diff)
The file was modifiedsrc/FileSystem-Core/FileSystemDirectoryEntry.class.st (diff)
Commit 1edf57512eaa51a2b010035813ba092162a245a1 by akgrant0710
WindowsStore>>directoryAt:nodesDo: &
DiskFileSystemTest>>testLongFilename
The file was modifiedsrc/FileSystem-Tests-Disk/DiskFileSystemTest.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/WindowsStore.class.st (diff)
Commit 33bd43706f4f0b0da63584d64326271bda3cfa43 by akgrant0710
Add BOOTSTRAP_VMTARGET to bootstrap scripts
This allows a specific VM to be used while building the new image.
The file was modifiedbootstrap/scripts/2-download.sh (diff)
The file was modifiedbootstrap/scripts/envvars.sh (diff)
Commit 232472a1663fc76747c8122e881d549f28f3268d by akgrant0710
FileSystem>>move:to: do nothing if the source and destination are the
same
The file was modifiedsrc/FileSystem-Core/FileSystem.class.st (diff)
Commit 7175ee6015844fe2bbb25fd05133fe16f3617fdf by akgrant0710
envvars.sh: check for unset variable (not empty)
The file was modifiedbootstrap/scripts/envvars.sh (diff)
Commit 74c7f150c635a0e353d2d692a89c68676d99dca3 by akgrant0710
Modify File Attributes to reflect updated windows attributes
The file was modifiedsrc/FileSystem-Tests-Attributes/FileReferenceAttributeTests.class.st (diff)
The file was modifiedsrc/FileSystem-Tests-Attributes/DiskFileAttributesTests.class.st (diff)
The file was modifiedsrc/FileSystem-Tests-Attributes/FileAttributesPluginPrimsTests.class.st (diff)
The file was modifiedsrc/Files/File.class.st (diff)
The file was modifiedsrc/FileSystem-Core/DiskDirectoryEntry.class.st (diff)