FailedChanges

Summary

  1. CompletionContext should check the editor if we are in a workspace or (details)
  2. nil check if editor is not set (details)
  3. fix type inference for "self", so now code completion knows that "self" (details)
  4. lookupDefiningContextFor: startingFrom:  was using variable names. It is (details)
  5. forgot to remove "*not*" (details)
Commit a8713fd2277064d65835eb4d5f9bd57b0f10d6c6 by marcus.denker
CompletionContext should check the editor if we are in a workspace or
not. fixes #4686
(the setter of CompletionContext will be cleaned up more when we remove
the old completion)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/RBProgramNode.extension.st (diff)
Commit 5be62ef3029d5ab7533e79a8b7fed3e795eb6f72 by marcus.denker
nil check if editor is not set
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit 8d4cb2a70a8459635b52b7baca3e80f97337ea8e by marcus.denker
fix type inference for "self", so now code completion knows that "self"
is a SmallInteger when inspecting "1"
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/RBMethodNode.extension.st (diff)
Commit d2994b4b40d53c0ca8a10e1f04e6b746c7409df2 by marcus.denker
lookupDefiningContextFor: startingFrom:  was using variable names. It is
better to instead walk up contexts till the scope is the definition
scope of the variable (independend of the name).
The file was modifiedsrc/OpalCompiler-Tests/OCClosureCompilerTest.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/OCAbstractMethodScope.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/OCTempVariable.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/OCCopyingTempVariable.class.st (diff)
The file was modifiedsrc/OpalCompiler-Tests/MethodMapTest.class.st (diff)
Commit fb8319e845dcfd5aa6f0c404b5e3454f8bbf5288 by marcus.denker
forgot to remove "*not*"
The file was modifiedsrc/OpalCompiler-Tests/MethodMapTest.class.st (diff)