Changes

Summary

  1. [fix] fixes issue #6088 (details)
  2. [improvement] rename to a name that correctly reflects what it does. (details)
  3. [improvement] add isArgOrTempSelected. (details)
  4. [improvement] another rename to better reflect AST visiion. (details)
  5. [fix] remove usage of isArgOrTemp, which is for compiler usage. (details)
  6. [tests] added tests to support PR #65195's claims. (details)
  7. cleanup external dependencies (details)
  8. Remove the sound player process from the process browser hard coded (details)
  9. Extract returns from conditionals for packages starting by a to c (details)
  10. Further simplification of the code (details)
  11. Extract returns from conditionals for packages starting by d to f (details)
  12. Extract returns from conditionals for packages starting by g (details)
  13. Extract returns from conditionals for packages starting by m (details)
  14. Extract returns from conditionals for packages starting by n (details)
  15. fixes: #6435 cleaning obvious references I stupidly ma (details)
  16. Fixing #5451 (details)
The file was modifiedsrc/Calypso-SystemTools-Core/ClySourceCodeContext.class.st (diff)
Commit 7dcc7ce600f7b0471e31602a5b70501353558fe3 by pierre_misse25
[improvement] rename to a name that correctly reflects what it does.
The file was removedsrc/SystemCommands-SourceCodeCommands/SycRenameTempCommand.class.st
The file was addedsrc/SystemCommands-SourceCodeCommands/SycRenameArgOrTempCommand.class.st
Commit 3f0061de16142303337eac790008c074fcb5254e by pierre_misse25
[improvement] add isArgOrTempSelected.
The file was modifiedsrc/Calypso-SystemTools-Core/ClySourceCodeContext.class.st (diff)
The file was modifiedsrc/Calypso-SystemTools-Core/SycRenameTempCommand.extension.st (diff)
The file was modifiedsrc/Refactoring-Help/RBBrowserSourceRefactoringHelp.class.st (diff)
The file was modifiedsrc/Refactoring-Tests-Core/RBRenameTemporaryTest.class.st (diff)
Commit f8c9d73f571eb8816218bd0949a05638c8950bac by pierre_misse25
[improvement] another rename to better reflect AST visiion.
The file was removedsrc/Refactoring-Core/RBRenameTemporaryRefactoring.class.st
The file was removedsrc/Calypso-SystemTools-Core/SycRenameTempCommand.extension.st
The file was addedsrc/Calypso-SystemTools-Core/SycRenameArgOrTempCommand.extension.st
The file was modifiedsrc/GeneralRules/ReTemporaryVariableCapitalizationRule.class.st (diff)
The file was modifiedsrc/NautilusRefactoring/NautilusRefactoring.class.st (diff)
The file was addedsrc/Refactoring-Core/RBRenameArgumentOrTemporaryRefactoring.class.st
Commit 02ec5c4ba85c1de98fe1b1c57982c6fce4860207 by pierre_misse25
[fix] remove usage of isArgOrTemp, which is for compiler usage.
The file was modifiedsrc/SystemCommands-SourceCodeCommands/SycRenameArgOrTempCommand.class.st (diff)
The file was modifiedsrc/Calypso-SystemTools-Core/ClySourceCodeContext.class.st (diff)
Commit b3c4e9656aeb7963572e755e6aac6390da7637a8 by pierre_misse25
[tests] added tests to support PR #65195's claims.
The file was addedsrc/SystemCommands-MethodCommands-Tests/SycConvertTempToinstVarCommandTest.class.st
The file was addedsrc/SystemCommands-MethodCommands-Tests/SycInlineTempCommandTest.class.st
The file was addedsrc/SystemCommands-MethodCommands-Tests/package.st
The file was addedsrc/SystemCommands-MethodCommands-Tests/SycRenameArgOrTempCommandTest.class.st
Commit bbdf8487d1b9aa4e0fea0f58b163554182af8401 by pavel.krivanek
cleanup external dependencies
The file was removedsrc/Reflectivity/TRBProgramNodeVisitor.extension.st
The file was modifiedsrc/AST-Core-Traits/TRBProgramNodeVisitor.trait.st (diff)
The file was modifiedsrc/BaselineOfTraits/BaselineOfTraits.class.st (diff)
The file was modifiedsrc/System-DependenciesTests/SystemDependenciesTest.class.st (diff)
The file was modifiedsrc/SUnit-Tests/ClassFactoryForTestCaseTest.class.st (diff)
The file was modifiedsrc/BaselineOfShout/BaselineOfShout.class.st (diff)
Commit 4a3b2ac59211718a9af17a7e8c13b688e108a5e2 by roniesalg
Remove the sound player process from the process browser hard coded
registration list.
The file was modifiedsrc/Tool-ProcessBrowser/ProcessBrowser.class.st (diff)
Commit e5b6b3bf92f4223ea01bbc92e208d3063ba48436 by cyril
Extract returns from conditionals for packages starting by a to c
This makes the code more readable since we can directly know that the
conditional will necessarily return something and the execution can be
stoped.
The file was modifiedsrc/Compression/ZipEncoderNode.class.st (diff)
The file was modifiedsrc/Collections-Arithmetic/WordArray.extension.st (diff)
The file was modifiedsrc/Collections-Support/WeakKeyAssociation.class.st (diff)
The file was modifiedsrc/Collections-Support/LookupKey.class.st (diff)
The file was modifiedsrc/Collections-Streams/PositionableStream.class.st (diff)
The file was modifiedsrc/Colors/Color.class.st (diff)
The file was modifiedsrc/Collections-Sequenceable/OrderedDictionary.class.st (diff)
The file was modifiedsrc/Collections-Sequenceable/Interval.class.st (diff)
The file was modifiedsrc/Collections-Strings/ByteString.class.st (diff)
The file was modifiedsrc/Collections-Sequenceable/SortedCollection.class.st (diff)
The file was modifiedsrc/Collections-Streams/WriteStream.class.st (diff)
The file was modifiedsrc/Compression/ZipEncoder.class.st (diff)
The file was modifiedsrc/Collections-Weak/WeakSet.class.st (diff)
The file was modifiedsrc/Compression/InflateStream.class.st (diff)
The file was modifiedsrc/Collections-Streams/ReadStream.class.st (diff)
The file was modifiedsrc/AST-Core/RBParser.class.st (diff)
The file was modifiedsrc/BlueInk-Core/BIConfigurableFormatter.class.st (diff)
The file was modifiedsrc/Collections-Strings/String.class.st (diff)
Commit 4fba1122683e7f575714f88ab99c4807f1db0474 by cyril
Further simplification of the code
The file was modifiedsrc/Collections-Arithmetic/WordArray.extension.st (diff)
Commit d3c960ee0347f3dcd1870b070a9e06d84bd93f69 by cyril
Extract returns from conditionals for packages starting by d to f
This makes the code more readable since we can directly know that the
conditional will necessarily return something and the execution can be
stoped.
The file was modifiedsrc/FormCanvas-Core/LineSegment.class.st (diff)
The file was modifiedsrc/DeprecatedFileStream/RWBinaryOrTextStream.class.st (diff)
The file was modifiedsrc/DeprecatedFileStream/StandardFileStream.class.st (diff)
The file was modifiedsrc/DrTests-CommentsToTests/CommentTestCase.class.st (diff)
The file was modifiedsrc/EnlumineurFormatter/EFFormatter.class.st (diff)
The file was modifiedsrc/DeprecatedFileStream/FileStream.class.st (diff)
Commit a070dac75fa013a9cc6a889864ccebc35da16588 by cyril
Extract returns from conditionals for packages starting by g
This makes the code more readable since we can directly know that the
conditional will necessarily return something and the execution can be
stoped.
The file was modifiedsrc/Graphics-Primitives/Bitmap.class.st (diff)
The file was modifiedsrc/Glamour-Morphic-Brick/GLMInteractableBrick.class.st (diff)
The file was modifiedsrc/Graphics-Transformations/MorphicTransform.class.st (diff)
The file was modifiedsrc/Graphics-Display Objects/DisplayScreen.class.st (diff)
The file was modifiedsrc/Graphics-Files/JPEGReadWriter.class.st (diff)
The file was modifiedsrc/Graphics-Canvas/ShadowDrawingCanvas.class.st (diff)
The file was modifiedsrc/Glamour-PagerModel/GLMPagerModel.class.st (diff)
The file was modifiedsrc/Graphics-Display Objects/Form.class.st (diff)
The file was modifiedsrc/GT-Debugger/GTChangeDebuggerAction.class.st (diff)
The file was modifiedsrc/Graphics-Files/PNGReadWriter.class.st (diff)
The file was modifiedsrc/Graphics-Primitives/WarpBlt.class.st (diff)
The file was modifiedsrc/Graphics-Fonts/StrikeFont.class.st (diff)
The file was modifiedsrc/Graphics-Primitives/Color.extension.st (diff)
Commit 2d6d1dcbc37310ace39d05f26a75a95d0592bc4c by cyril
Extract returns from conditionals for packages starting by m
This makes the code more readable since we can directly know that the
conditional will necessarily return something and the execution can be
stoped.
The file was modifiedsrc/MonticelloGUI/MCFileRepositoryInspector.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-Tree/MorphTreeListManager.class.st (diff)
The file was modifiedsrc/Moose-Algos-Graph/MalGraphAlgorithm.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-FastTable/FTAllItemsStrategy.class.st (diff)
The file was modifiedsrc/Morphic-Base/StringMorph.class.st (diff)
The file was modifiedsrc/Math-Operations-Extensions/SmallFloat64.extension.st (diff)
The file was modifiedsrc/Morphic-Widgets-Windows/SystemWindow.class.st (diff)
The file was modifiedsrc/Morphic-Base/TextLine.class.st (diff)
The file was modifiedsrc/Morphic-Base/TextMorph.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-Tree/MorphTreeMorph.class.st (diff)
The file was modifiedsrc/Morphic-Base/EmbeddedMenuMorph.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-PolyTabs/TabSelectorMorph.class.st (diff)
The file was modifiedsrc/Morphic-Core/ExternalDropHandler.class.st (diff)
The file was modifiedsrc/Morphic-Core/Morph.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-Scrolling/ScrollPane.class.st (diff)
The file was modifiedsrc/Math-Operations-Extensions/BoxedFloat64.extension.st (diff)
The file was modifiedsrc/Morphic-Widgets-Scrolling/ScrollBar.class.st (diff)
The file was modifiedsrc/Math-Operations-Extensions/Float.extension.st (diff)
The file was modifiedsrc/Morphic-Core/TransformMorph.class.st (diff)
The file was modifiedsrc/Math-Operations-Extensions/Integer.extension.st (diff)
The file was modifiedsrc/Morphic-Base/PolygonMorph.class.st (diff)
The file was modifiedsrc/Metacello-Core/MetacelloVersionNumber.class.st (diff)
The file was modifiedsrc/Morphic-Base/MenuMorph.class.st (diff)
The file was modifiedsrc/Morphic-Core/HandMorph.class.st (diff)
The file was modifiedsrc/Metacello-Core/MetacelloSemanticVersionNumber.class.st (diff)
Commit 76c6220ab92cf6bc1530f6c9b09b28d5334ecd0e by cyril
Extract returns from conditionals for packages starting by n
This makes the code more readable since we can directly know that the
conditional will necessarily return something and the execution can be
stoped.
The file was modifiedsrc/Network-Kernel/SocketStream.class.st (diff)
The file was modifiedsrc/Network-Kernel/Socket.class.st (diff)
The file was modifiedsrc/NumberParser/NumberParser.class.st (diff)
The file was modifiedsrc/Network-Kernel/NetNameResolver.class.st (diff)
The file was modifiedsrc/Network-Protocols/ProtocolClient.class.st (diff)
Commit d2973dbaf914c103f0ecab02c099901751dfa5b9 by stephane.ducasse
fixes: #6435 cleaning obvious references I stupidly ma
The file was modifiedsrc/EnlumineurFormatter-Tests/EFBenchTest.class.st (diff)
The file was modifiedsrc/AST-Core/RBScanner.class.st (diff)

Summary

  1. [fix] fixes issue #6088 (details)
  2. [improvement] rename to a name that correctly reflects what it does. (details)
  3. [improvement] add isArgOrTempSelected. (details)
  4. [improvement] another rename to better reflect AST visiion. (details)
  5. [fix] remove usage of isArgOrTemp, which is for compiler usage. (details)
  6. [tests] added tests to support PR #65195's claims. (details)
  7. cleanup external dependencies (details)
  8. Remove the sound player process from the process browser hard coded (details)
  9. Extract returns from conditionals for packages starting by a to c (details)
  10. Further simplification of the code (details)
  11. Extract returns from conditionals for packages starting by d to f (details)
  12. Extract returns from conditionals for packages starting by g (details)
  13. Extract returns from conditionals for packages starting by m (details)
  14. Extract returns from conditionals for packages starting by n (details)
  15. fixes: #6435 cleaning obvious references I stupidly ma (details)
  16. Fixing #5451 (details)
The file was modifiedsrc/Calypso-SystemTools-Core/ClySourceCodeContext.class.st (diff)
Commit 7dcc7ce600f7b0471e31602a5b70501353558fe3 by pierre_misse25
[improvement] rename to a name that correctly reflects what it does.
The file was addedsrc/SystemCommands-SourceCodeCommands/SycRenameArgOrTempCommand.class.st
The file was removedsrc/SystemCommands-SourceCodeCommands/SycRenameTempCommand.class.st
Commit 3f0061de16142303337eac790008c074fcb5254e by pierre_misse25
[improvement] add isArgOrTempSelected.
The file was modifiedsrc/Refactoring-Tests-Core/RBRenameTemporaryTest.class.st (diff)
The file was modifiedsrc/Calypso-SystemTools-Core/SycRenameTempCommand.extension.st (diff)
The file was modifiedsrc/Refactoring-Help/RBBrowserSourceRefactoringHelp.class.st (diff)
The file was modifiedsrc/Calypso-SystemTools-Core/ClySourceCodeContext.class.st (diff)
Commit f8c9d73f571eb8816218bd0949a05638c8950bac by pierre_misse25
[improvement] another rename to better reflect AST visiion.
The file was removedsrc/Calypso-SystemTools-Core/SycRenameTempCommand.extension.st
The file was modifiedsrc/GeneralRules/ReTemporaryVariableCapitalizationRule.class.st (diff)
The file was modifiedsrc/NautilusRefactoring/NautilusRefactoring.class.st (diff)
The file was addedsrc/Calypso-SystemTools-Core/SycRenameArgOrTempCommand.extension.st
The file was addedsrc/Refactoring-Core/RBRenameArgumentOrTemporaryRefactoring.class.st
The file was removedsrc/Refactoring-Core/RBRenameTemporaryRefactoring.class.st
Commit 02ec5c4ba85c1de98fe1b1c57982c6fce4860207 by pierre_misse25
[fix] remove usage of isArgOrTemp, which is for compiler usage.
The file was modifiedsrc/SystemCommands-SourceCodeCommands/SycRenameArgOrTempCommand.class.st (diff)
The file was modifiedsrc/Calypso-SystemTools-Core/ClySourceCodeContext.class.st (diff)
Commit b3c4e9656aeb7963572e755e6aac6390da7637a8 by pierre_misse25
[tests] added tests to support PR #65195's claims.
The file was addedsrc/SystemCommands-MethodCommands-Tests/SycInlineTempCommandTest.class.st
The file was addedsrc/SystemCommands-MethodCommands-Tests/SycRenameArgOrTempCommandTest.class.st
The file was addedsrc/SystemCommands-MethodCommands-Tests/SycConvertTempToinstVarCommandTest.class.st
The file was addedsrc/SystemCommands-MethodCommands-Tests/package.st
Commit bbdf8487d1b9aa4e0fea0f58b163554182af8401 by pavel.krivanek
cleanup external dependencies
The file was modifiedsrc/AST-Core-Traits/TRBProgramNodeVisitor.trait.st (diff)
The file was removedsrc/Reflectivity/TRBProgramNodeVisitor.extension.st
The file was modifiedsrc/System-DependenciesTests/SystemDependenciesTest.class.st (diff)
The file was modifiedsrc/BaselineOfShout/BaselineOfShout.class.st (diff)
The file was modifiedsrc/BaselineOfTraits/BaselineOfTraits.class.st (diff)
The file was modifiedsrc/SUnit-Tests/ClassFactoryForTestCaseTest.class.st (diff)
Commit 4a3b2ac59211718a9af17a7e8c13b688e108a5e2 by roniesalg
Remove the sound player process from the process browser hard coded
registration list.
The file was modifiedsrc/Tool-ProcessBrowser/ProcessBrowser.class.st (diff)
Commit e5b6b3bf92f4223ea01bbc92e208d3063ba48436 by cyril
Extract returns from conditionals for packages starting by a to c
This makes the code more readable since we can directly know that the
conditional will necessarily return something and the execution can be
stoped.
The file was modifiedsrc/BlueInk-Core/BIConfigurableFormatter.class.st (diff)
The file was modifiedsrc/Compression/ZipEncoder.class.st (diff)
The file was modifiedsrc/Collections-Strings/String.class.st (diff)
The file was modifiedsrc/Collections-Weak/WeakSet.class.st (diff)
The file was modifiedsrc/Collections-Streams/WriteStream.class.st (diff)
The file was modifiedsrc/Colors/Color.class.st (diff)
The file was modifiedsrc/Compression/ZipEncoderNode.class.st (diff)
The file was modifiedsrc/Collections-Arithmetic/WordArray.extension.st (diff)
The file was modifiedsrc/Collections-Sequenceable/Interval.class.st (diff)
The file was modifiedsrc/Collections-Sequenceable/SortedCollection.class.st (diff)
The file was modifiedsrc/Collections-Streams/PositionableStream.class.st (diff)
The file was modifiedsrc/Collections-Sequenceable/OrderedDictionary.class.st (diff)
The file was modifiedsrc/AST-Core/RBParser.class.st (diff)
The file was modifiedsrc/Collections-Support/LookupKey.class.st (diff)
The file was modifiedsrc/Collections-Streams/ReadStream.class.st (diff)
The file was modifiedsrc/Collections-Strings/ByteString.class.st (diff)
The file was modifiedsrc/Compression/InflateStream.class.st (diff)
The file was modifiedsrc/Collections-Support/WeakKeyAssociation.class.st (diff)
Commit 4fba1122683e7f575714f88ab99c4807f1db0474 by cyril
Further simplification of the code
The file was modifiedsrc/Collections-Arithmetic/WordArray.extension.st (diff)
Commit d3c960ee0347f3dcd1870b070a9e06d84bd93f69 by cyril
Extract returns from conditionals for packages starting by d to f
This makes the code more readable since we can directly know that the
conditional will necessarily return something and the execution can be
stoped.
The file was modifiedsrc/DeprecatedFileStream/StandardFileStream.class.st (diff)
The file was modifiedsrc/EnlumineurFormatter/EFFormatter.class.st (diff)
The file was modifiedsrc/DeprecatedFileStream/FileStream.class.st (diff)
The file was modifiedsrc/FormCanvas-Core/LineSegment.class.st (diff)
The file was modifiedsrc/DeprecatedFileStream/RWBinaryOrTextStream.class.st (diff)
The file was modifiedsrc/DrTests-CommentsToTests/CommentTestCase.class.st (diff)
Commit a070dac75fa013a9cc6a889864ccebc35da16588 by cyril
Extract returns from conditionals for packages starting by g
This makes the code more readable since we can directly know that the
conditional will necessarily return something and the execution can be
stoped.
The file was modifiedsrc/Graphics-Primitives/WarpBlt.class.st (diff)
The file was modifiedsrc/Glamour-Morphic-Brick/GLMInteractableBrick.class.st (diff)
The file was modifiedsrc/Graphics-Primitives/Bitmap.class.st (diff)
The file was modifiedsrc/Graphics-Files/PNGReadWriter.class.st (diff)
The file was modifiedsrc/GT-Debugger/GTChangeDebuggerAction.class.st (diff)
The file was modifiedsrc/Graphics-Display Objects/Form.class.st (diff)
The file was modifiedsrc/Graphics-Primitives/Color.extension.st (diff)
The file was modifiedsrc/Graphics-Fonts/StrikeFont.class.st (diff)
The file was modifiedsrc/Graphics-Transformations/MorphicTransform.class.st (diff)
The file was modifiedsrc/Graphics-Display Objects/DisplayScreen.class.st (diff)
The file was modifiedsrc/Glamour-PagerModel/GLMPagerModel.class.st (diff)
The file was modifiedsrc/Graphics-Canvas/ShadowDrawingCanvas.class.st (diff)
The file was modifiedsrc/Graphics-Files/JPEGReadWriter.class.st (diff)
Commit 2d6d1dcbc37310ace39d05f26a75a95d0592bc4c by cyril
Extract returns from conditionals for packages starting by m
This makes the code more readable since we can directly know that the
conditional will necessarily return something and the execution can be
stoped.
The file was modifiedsrc/Morphic-Core/TransformMorph.class.st (diff)
The file was modifiedsrc/Math-Operations-Extensions/SmallFloat64.extension.st (diff)
The file was modifiedsrc/Morphic-Widgets-Tree/MorphTreeMorph.class.st (diff)
The file was modifiedsrc/Morphic-Base/StringMorph.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-PolyTabs/TabSelectorMorph.class.st (diff)
The file was modifiedsrc/Morphic-Base/MenuMorph.class.st (diff)
The file was modifiedsrc/Morphic-Base/EmbeddedMenuMorph.class.st (diff)
The file was modifiedsrc/Morphic-Base/TextLine.class.st (diff)
The file was modifiedsrc/Morphic-Core/ExternalDropHandler.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-Scrolling/ScrollBar.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-Scrolling/ScrollPane.class.st (diff)
The file was modifiedsrc/MonticelloGUI/MCFileRepositoryInspector.class.st (diff)
The file was modifiedsrc/Morphic-Base/TextMorph.class.st (diff)
The file was modifiedsrc/Math-Operations-Extensions/Integer.extension.st (diff)
The file was modifiedsrc/Moose-Algos-Graph/MalGraphAlgorithm.class.st (diff)
The file was modifiedsrc/Math-Operations-Extensions/BoxedFloat64.extension.st (diff)
The file was modifiedsrc/Math-Operations-Extensions/Float.extension.st (diff)
The file was modifiedsrc/Metacello-Core/MetacelloSemanticVersionNumber.class.st (diff)
The file was modifiedsrc/Morphic-Core/HandMorph.class.st (diff)
The file was modifiedsrc/Morphic-Base/PolygonMorph.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-FastTable/FTAllItemsStrategy.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-Windows/SystemWindow.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-Tree/MorphTreeListManager.class.st (diff)
The file was modifiedsrc/Morphic-Core/Morph.class.st (diff)
The file was modifiedsrc/Metacello-Core/MetacelloVersionNumber.class.st (diff)
Commit 76c6220ab92cf6bc1530f6c9b09b28d5334ecd0e by cyril
Extract returns from conditionals for packages starting by n
This makes the code more readable since we can directly know that the
conditional will necessarily return something and the execution can be
stoped.
The file was modifiedsrc/Network-Kernel/NetNameResolver.class.st (diff)
The file was modifiedsrc/Network-Kernel/Socket.class.st (diff)
The file was modifiedsrc/NumberParser/NumberParser.class.st (diff)
The file was modifiedsrc/Network-Kernel/SocketStream.class.st (diff)
The file was modifiedsrc/Network-Protocols/ProtocolClient.class.st (diff)
Commit d2973dbaf914c103f0ecab02c099901751dfa5b9 by stephane.ducasse
fixes: #6435 cleaning obvious references I stupidly ma
The file was modifiedsrc/EnlumineurFormatter-Tests/EFBenchTest.class.st (diff)
The file was modifiedsrc/AST-Core/RBScanner.class.st (diff)