SuccessChanges

Summary

  1. On the level of both the AST and the Variables, #isGlobal returns true (details)
  2. fix test. Yes, we have to revisit this as soon as everything is clean (details)
  3. Nope. The thing was that on the Variable level, all LiteralVariables (details)
  4. better fix: implement #isGlobal on the AST level with the semantic that (details)
Commit 59d8fae8a1245caafa5792b38f0d145ba654efc4 by marcus.denker
On the level of both the AST and the Variables, #isGlobal returns true
for all Literal Variables. That is not good, e.g.:
(SmalltalkImage classVariableNamed: #CompilerClass) isGlobal
- This PR checks and fixes all senders that send #isGlobal to a Variable

- Then it changes #isGlobal to be in sync with isGlobalVariable
The AST level is not touched! There #isGlobal still returns true for
class var nodes (future work) Another future work is to decide if we
merge isGlobalVariable and isGlobal on the level of the Variables and
just have one of the two.
The file was modifiedsrc/Kernel/LiteralVariable.class.st (diff)
The file was modifiedsrc/Kernel/GlobalVariable.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/RBVariableNode.extension.st (diff)
The file was modifiedsrc/Kernel/UndeclaredVariable.class.st (diff)
The file was modifiedsrc/Reflectivity/RFOperationReification.class.st (diff)
The file was modifiedsrc/Reflectivity/RFValueReification.class.st (diff)
Commit 9f042de142be32f8a5a7d47165c854701ea60381 by marcus.denker
fix test. Yes, we have to revisit this as soon as everything is clean
The file was modifiedsrc/Shout/SHRBTextStyler.class.st (diff)
Commit 4422130db1b2b06181fd2a8199448ec2d28aee57 by marcus.denker
Nope. The thing was that on the Variable level, all LiteralVariables
where isGlobal, but UndefinedVariable not! So we just have to check for
that case here
The file was modifiedsrc/Shout/SHRBTextStyler.class.st (diff)
Commit f852d7fbbf06bea87f16dc77c487e1960b7cd6ae by marcus.denker
better fix: implement #isGlobal on the AST level with the semantic that
it is not global if it is isUndeclared
The file was modifiedsrc/Shout/SHRBTextStyler.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/RBVariableNode.extension.st (diff)

Summary

  1. On the level of both the AST and the Variables, #isGlobal returns true (details)
  2. fix test. Yes, we have to revisit this as soon as everything is clean (details)
  3. Nope. The thing was that on the Variable level, all LiteralVariables (details)
  4. better fix: implement #isGlobal on the AST level with the semantic that (details)
Commit 59d8fae8a1245caafa5792b38f0d145ba654efc4 by marcus.denker
On the level of both the AST and the Variables, #isGlobal returns true
for all Literal Variables. That is not good, e.g.:
(SmalltalkImage classVariableNamed: #CompilerClass) isGlobal
- This PR checks and fixes all senders that send #isGlobal to a Variable

- Then it changes #isGlobal to be in sync with isGlobalVariable
The AST level is not touched! There #isGlobal still returns true for
class var nodes (future work) Another future work is to decide if we
merge isGlobalVariable and isGlobal on the level of the Variables and
just have one of the two.
The file was modifiedsrc/Reflectivity/RFOperationReification.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/RBVariableNode.extension.st (diff)
The file was modifiedsrc/Kernel/GlobalVariable.class.st (diff)
The file was modifiedsrc/Kernel/UndeclaredVariable.class.st (diff)
The file was modifiedsrc/Reflectivity/RFValueReification.class.st (diff)
The file was modifiedsrc/Kernel/LiteralVariable.class.st (diff)
Commit 9f042de142be32f8a5a7d47165c854701ea60381 by marcus.denker
fix test. Yes, we have to revisit this as soon as everything is clean
The file was modifiedsrc/Shout/SHRBTextStyler.class.st (diff)
Commit 4422130db1b2b06181fd2a8199448ec2d28aee57 by marcus.denker
Nope. The thing was that on the Variable level, all LiteralVariables
where isGlobal, but UndefinedVariable not! So we just have to check for
that case here
The file was modifiedsrc/Shout/SHRBTextStyler.class.st (diff)
Commit f852d7fbbf06bea87f16dc77c487e1960b7cd6ae by marcus.denker
better fix: implement #isGlobal on the AST level with the semantic that
it is not global if it is isUndeclared
The file was modifiedsrc/Shout/SHRBTextStyler.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/RBVariableNode.extension.st (diff)