Changes

Summary

  1. The names of the testing methods for Variables (and VariableNodes) are (details)
Commit fbd8f91e935a4fcc6f7280777201e84792f3dcb9 by marcus.denker
The names of the testing methods for Variables (and VariableNodes) are
not good. #isGlobal works, but it breakes down with #isInstance...
As one step, this PR just makes sure that all the "nice" variable check
methos exist on the Variable hierarchy
- add missing (e.g. isTemporaryVariable)
- the short versions forward to the new and have a comment that they
will be deprecated
- add comments to the version on Variable for those that are not obvious
(eg isLiteralVariable, the term is not nice but that is what they are
called on the Bytecode level)
This PR does *not*
- change any senders
- modify the AST level
- isSelf/isSuper are skiped for now (they should be isSelfVariable, too)
The file was modifiedsrc/Deprecated90/OCSlotVariable.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/LocalVariable.class.st (diff)
The file was modifiedsrc/Deprecated90/OCAbstractLocalVariable.class.st (diff)
The file was modifiedsrc/Deprecated90/OCLiteralVariable.class.st (diff)
The file was modifiedsrc/Kernel/Slot.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/TemporaryVariable.class.st (diff)
The file was modifiedsrc/Deprecated90/OCAbstractVariable.class.st (diff)
The file was modifiedsrc/Kernel/Variable.class.st (diff)
The file was modifiedsrc/Kernel/GlobalVariable.class.st (diff)

Summary

  1. The names of the testing methods for Variables (and VariableNodes) are (details)
Commit fbd8f91e935a4fcc6f7280777201e84792f3dcb9 by marcus.denker
The names of the testing methods for Variables (and VariableNodes) are
not good. #isGlobal works, but it breakes down with #isInstance...
As one step, this PR just makes sure that all the "nice" variable check
methos exist on the Variable hierarchy
- add missing (e.g. isTemporaryVariable)
- the short versions forward to the new and have a comment that they
will be deprecated
- add comments to the version on Variable for those that are not obvious
(eg isLiteralVariable, the term is not nice but that is what they are
called on the Bytecode level)
This PR does *not*
- change any senders
- modify the AST level
- isSelf/isSuper are skiped for now (they should be isSelfVariable, too)
The file was modifiedsrc/OpalCompiler-Core/TemporaryVariable.class.st (diff)
The file was modifiedsrc/Kernel/GlobalVariable.class.st (diff)
The file was modifiedsrc/Deprecated90/OCSlotVariable.class.st (diff)
The file was modifiedsrc/Deprecated90/OCAbstractLocalVariable.class.st (diff)
The file was modifiedsrc/Kernel/Slot.class.st (diff)
The file was modifiedsrc/Deprecated90/OCLiteralVariable.class.st (diff)
The file was modifiedsrc/Deprecated90/OCAbstractVariable.class.st (diff)
The file was modifiedsrc/Kernel/Variable.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/LocalVariable.class.st (diff)