Changes

Summary

  1. willCreateBlock does not detect full blocks, this leads to to problems (details)
  2. Fix for the test, it was not doing a needed step... (details)
  3. No sure about these... (details)
  4. Fixes: #6838 cleaning squeak refs the lesser the better (details)
  5. make sure to access literals with #literalAt: and skip the (details)
  6. antother fix.. (details)
  7. off by one fixed (details)
  8. do not change #sameLiteralsAs: (details)
  9. - fix some tiny mistakes of the last PRs - rename declaringNode to (details)
  10. isInstanceVariable instead of twice isLiteralVariable (details)
  11. - remove classAdded: on the instance side: dead code - implement enabled (details)
  12. fix a test (details)
  13. ReReferencesObsoleteClassRule, fix ReGlobalVariablesUsageRule as it was (details)
  14. isGlobalClassNameBinding needs to return true for obsolete classes... (details)
  15. ReGlobalVariablesUsageRule : switch around test (details)
  16. reduce references to RBVariableNode subclasses (details)
Commit 0066bdfde34b78c23d5445941b16f353d86f2dba by marcus.denker
willCreateBlock does not detect full blocks, this leads to to problems
in the debugger that temps are read from the wrong context
The file was modifiedsrc/Kernel-BytecodeEncoders/EncoderForSistaV1.class.st (diff)
The file was modifiedsrc/Kernel-BytecodeEncoders/EncoderForV3PlusClosures.class.st (diff)
The file was modifiedsrc/Debugging-Core/InstructionStream.extension.st (diff)
Commit 728751a2b90c2a5cce53390d16cb0c9c66c26bc5 by marcus.denker
Fix for the test, it was not doing a needed step...
The file was modifiedsrc/Debugger-Tests/DebuggerTest.class.st (diff)
Commit f5614bd6817fec8497b2c052afb5aa20e3d7e19e by marcus.denker
No sure about these...
- step only once in testStepIntoAssignment and testStepOverAssignment.
Why did we step twice?
- context of the block has size 2
The file was modifiedsrc/Debugger-Tests/AssignmentAndLiteralDebuggerTest.class.st (diff)
Commit aad1f4cc0a7fcff3fc0377671677b2d6e8efe8d1 by stephane.ducasse
Fixes: #6838 cleaning squeak refs the lesser the better
The file was modifiedsrc/Rubric/RubTextStopConditions.class.st (diff)
The file was modifiedsrc/Collections-Atomic-Tests/FIFOQueueTest.class.st (diff)
The file was modifiedsrc/Morphic-Widgets-Basic/PluggableButtonMorph.class.st (diff)
The file was modifiedsrc/Glamour-Helpers/BlockClosure.extension.st (diff)
The file was modifiedsrc/Kernel-Tests/FloatTest.class.st (diff)
The file was modifiedsrc/Kernel/Timespan.class.st (diff)
The file was modifiedsrc/Athens-Cairo/AthensCairoSurface.class.st (diff)
The file was modifiedsrc/System-Support/VirtualMachine.class.st (diff)
The file was modifiedsrc/Fuel-Tests-Core/FLHashedCollectionSerializationTest.class.st (diff)
The file was modifiedsrc/Compression/GZipReadStream.class.st (diff)
The file was modifiedsrc/MonticelloRemoteRepositories/MCSqueaksourceRepository.class.st (diff)
The file was modifiedsrc/Kernel/DateAndTime.class.st (diff)
The file was modifiedsrc/MonticelloRemoteRepositories/MCSmalltalkhubRepository.class.st (diff)
The file was modifiedsrc/Kernel/Time.class.st (diff)
The file was modifiedsrc/Kernel/DelayMicrosecondTicker.class.st (diff)
The file was modifiedsrc/Network-Kernel/NetNameResolver.class.st (diff)
The file was modifiedsrc/Collections-Tests/SharedQueueTest.class.st (diff)
The file was modifiedsrc/Kernel-Tests-Extended/DelayTest.extension.st (diff)
The file was modifiedsrc/Metacello-ProfStef/MetacelloConfigurationTutorialPart1.class.st (diff)
The file was modifiedsrc/Collections-Atomic-Tests/LIFOQueueTest.class.st (diff)
The file was modifiedsrc/Compression/CompiledMethodTrailer.extension.st (diff)
The file was modifiedsrc/Ring-Definitions-Core/RGElementDefinition.class.st (diff)
The file was modifiedsrc/MonticelloRemoteRepositories/MCFtpRepository.class.st (diff)
The file was modifiedsrc/Kernel/Float.class.st (diff)
The file was modifiedsrc/MonticelloRemoteRepositories/MCGemstoneRepository.class.st (diff)
The file was modifiedsrc/Kernel-Tests-Extended/FloatTest.extension.st (diff)
The file was modifiedsrc/Morphic-Core/WorldState.class.st (diff)
The file was modifiedsrc/HelpSystem-Core/HelpHowToHelpTopics.class.st (diff)
The file was modifiedsrc/Kernel-Chronology-Extras/DateAndTime.extension.st (diff)
The file was modifiedsrc/Morphic-Tests/PolygonMorphTest.class.st (diff)
The file was modifiedsrc/Ring-Core/RGStampParser.class.st (diff)
The file was modifiedsrc/Glamour-Helpers/MessageSend.extension.st (diff)
The file was modifiedsrc/Collections-Unordered-Tests/DictionaryTest.class.st (diff)
The file was modifiedsrc/System-Support/SmalltalkImage.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/ReSmalllintTest.class.st (diff)
The file was modifiedsrc/Graphics-Display Objects/Form.class.st (diff)
The file was modifiedsrc/Refactoring2-Transformations-Tests/RBBasicDummyLintRuleTest.class.st (diff)
The file was modifiedsrc/Compression/ZipFileMember.class.st (diff)
The file was modifiedsrc/Kernel-Chronology-Extras/Integer.extension.st (diff)
The file was modifiedsrc/Files/AsyncFile.class.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
The file was modifiedsrc/Metacello-Base/Metacello.class.st (diff)
Commit 06e021784f8d24d0847b464392def9e33ceb2634 by marcus.denker
make sure to access literals with #literalAt: and skip the
#literalsToSkip at the end
The file was modifiedsrc/Kernel/CompiledCode.class.st (diff)
The file was modifiedsrc/Kernel/CompiledCode.class.st (diff)
The file was modifiedsrc/Kernel/CompiledCode.class.st (diff)
Commit 019613562736d61eb8500f157140db5cb435c6d0 by marcus.denker
do not change #sameLiteralsAs:
The file was modifiedsrc/Kernel/CompiledCode.class.st (diff)
Commit 00ecd96b246780ba588733c2d40d700dbe1924e7 by marcus.denker
- fix some tiny mistakes of the last PRs - rename declaringNode to
definingNode - implement isDefinition in terms of definingNode - add
#instanceVariables to Behavior returning Slots - remove #isSlot
introduces in the Variable hierarhchy (we have isInstanceVariable) -
remove #isObservable: Slot users should not add extension method if it
an be avoided
The file was modifiedsrc/OpalCompiler-Core/LocalVariable.class.st (diff)
The file was modifiedsrc/Calypso-Ring/RGMethod.extension.st (diff)
The file was modifiedsrc/Kernel/Slot.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/TemporaryVariable.class.st (diff)
The file was modifiedsrc/Slot-Tests/ArgumentVariableTest.class.st (diff)
The file was modifiedsrc/Kernel/Behavior.class.st (diff)
The file was modifiedsrc/Slot-Tests/TemporaryVariableTest.class.st (diff)
The file was modifiedsrc/System-Support/Class.extension.st (diff)
The file was modifiedsrc/OpalCompiler-Core/ArgumentVariable.class.st (diff)
The file was removedsrc/VariablesLibrary/Slot.extension.st
The file was modifiedsrc/VariablesLibrary/ObservableSlot.class.st (diff)
The file was modifiedsrc/AST-Core/RBVariableNode.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/RBVariableNode.extension.st (diff)
The file was modifiedsrc/AST-Core/RBProgramNode.class.st (diff)
The file was modifiedsrc/VariablesLibrary/TObservable.trait.st (diff)
The file was modifiedsrc/Calypso-SystemTools-Core/ClySourceCodeContext.class.st (diff)
The file was modifiedsrc/Kernel/Variable.class.st (diff)
Commit 161ae96e2db055ce532a831e63354ee0372409e9 by marcus.denker
isInstanceVariable instead of twice isLiteralVariable
The file was modifiedsrc/Calypso-SystemTools-Core/ClySourceCodeContext.class.st (diff)
Commit d572f23f38d496d87e5fc8042905f885379e846b by marcus.denker
- remove classAdded: on the instance side: dead code - implement enabled
and enabled: on RBLintRule - clean up all the code that just was there
because of these methods not implemenented
The file was modifiedsrc/Renraku/ReRuleManager.class.st (diff)
The file was modifiedsrc/Renraku/ReImageRuleBaner.class.st (diff)
The file was modifiedsrc/Refactoring-Critics/RBLintRule.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/LocalVariable.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/ReSuperWithoutSendTest.class.st (diff)
Commit 4d6fda9e217010d914be898459c3bdd4a0488235 by marcus.denker
ReReferencesObsoleteClassRule, fix ReGlobalVariablesUsageRule as it was
wrongly detecting
The file was modifiedsrc/GeneralRules/ReGlobalVariablesUsageRule.class.st (diff)
The file was addedsrc/GeneralRules/ReReferencesObsoleteClassRule.class.st
Commit cac870f8032602ffdeb237bea51177f2ff968a0b by marcus.denker
isGlobalClassNameBinding needs to return true for obsolete classes...
because they are classes
The file was modifiedsrc/GeneralRules/ReReferencesObsoleteClassRule.class.st (diff)
The file was modifiedsrc/GeneralRules/ReGlobalVariablesUsageRule.class.st (diff)
The file was modifiedsrc/Kernel/LiteralVariable.class.st (diff)
Commit 84ac45de740f3ab867eae1886d031a521f54d100 by marcus.denker
ReGlobalVariablesUsageRule : switch around test
The file was modifiedsrc/GeneralRules/ReGlobalVariablesUsageRule.class.st (diff)
Commit 9531aabfc50a3144aca3dc424ee90d5230dbb95d by marcus.denker
reduce references to RBVariableNode subclasses
The AST should only know variables. Givign meaning to it is done by
semantic analysis.
The file was modifiedsrc/Calypso-SystemPlugins-Reflectivity-Browser-Tests/ClyInstallMetaLinkPresenterTest.class.st (diff)
The file was modifiedsrc/AST-Core-Tests/RBDumpVisitorTest.class.st (diff)
The file was modifiedsrc/OpalCompiler-Tests/OCVariableSpecialisationTest.class.st (diff)
The file was modifiedsrc/Reflectivity/RFValueReification.class.st (diff)
The file was modifiedsrc/Reflectivity/RFArgumentsReification.class.st (diff)
The file was modifiedsrc/Reflectivity/RFOperationReification.class.st (diff)
The file was modifiedsrc/Reflectivity/RFMethodToExecuteReification.class.st (diff)
The file was modifiedsrc/Reflectivity/RFReceiverReification.class.st (diff)
The file was modifiedsrc/Reflectivity/RFNewValueReification.class.st (diff)

Summary

  1. willCreateBlock does not detect full blocks, this leads to to problems (details)
  2. Fix for the test, it was not doing a needed step... (details)
  3. No sure about these... (details)
  4. Fixes: #6838 cleaning squeak refs the lesser the better (details)
  5. make sure to access literals with #literalAt: and skip the (details)
  6. antother fix.. (details)
  7. off by one fixed (details)
  8. do not change #sameLiteralsAs: (details)
  9. - fix some tiny mistakes of the last PRs - rename declaringNode to (details)
  10. isInstanceVariable instead of twice isLiteralVariable (details)
  11. - remove classAdded: on the instance side: dead code - implement enabled (details)
  12. fix a test (details)
  13. ReReferencesObsoleteClassRule, fix ReGlobalVariablesUsageRule as it was (details)
  14. isGlobalClassNameBinding needs to return true for obsolete classes... (details)
  15. ReGlobalVariablesUsageRule : switch around test (details)
  16. reduce references to RBVariableNode subclasses (details)
Commit 0066bdfde34b78c23d5445941b16f353d86f2dba by marcus.denker
willCreateBlock does not detect full blocks, this leads to to problems
in the debugger that temps are read from the wrong context
The file was modifiedsrc/Kernel-BytecodeEncoders/EncoderForV3PlusClosures.class.st (diff)
The file was modifiedsrc/Debugging-Core/InstructionStream.extension.st (diff)
The file was modifiedsrc/Kernel-BytecodeEncoders/EncoderForSistaV1.class.st (diff)
Commit 728751a2b90c2a5cce53390d16cb0c9c66c26bc5 by marcus.denker
Fix for the test, it was not doing a needed step...
The file was modifiedsrc/Debugger-Tests/DebuggerTest.class.st (diff)
Commit f5614bd6817fec8497b2c052afb5aa20e3d7e19e by marcus.denker
No sure about these...
- step only once in testStepIntoAssignment and testStepOverAssignment.
Why did we step twice?
- context of the block has size 2
The file was modifiedsrc/Debugger-Tests/AssignmentAndLiteralDebuggerTest.class.st (diff)
Commit aad1f4cc0a7fcff3fc0377671677b2d6e8efe8d1 by stephane.ducasse
Fixes: #6838 cleaning squeak refs the lesser the better
The file was modifiedsrc/MonticelloRemoteRepositories/MCGemstoneRepository.class.st (diff)
The file was modifiedsrc/Athens-Cairo/AthensCairoSurface.class.st (diff)
The file was modifiedsrc/Refactoring2-Transformations-Tests/RBBasicDummyLintRuleTest.class.st (diff)
The file was modifiedsrc/Glamour-Helpers/MessageSend.extension.st (diff)
The file was modifiedsrc/Kernel/Time.class.st (diff)
The file was modifiedsrc/Metacello-ProfStef/MetacelloConfigurationTutorialPart1.class.st (diff)
The file was modifiedsrc/Morphic-Tests/PolygonMorphTest.class.st (diff)
The file was modifiedsrc/Kernel-Tests-Extended/DelayTest.extension.st (diff)
The file was modifiedsrc/Morphic-Core/WorldState.class.st (diff)
The file was modifiedsrc/Kernel/DelayMicrosecondTicker.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/ReSmalllintTest.class.st (diff)
The file was modifiedsrc/MonticelloRemoteRepositories/MCSqueaksourceRepository.class.st (diff)
The file was modifiedsrc/MonticelloRemoteRepositories/MCFtpRepository.class.st (diff)
The file was modifiedsrc/Kernel-Tests-Extended/FloatTest.extension.st (diff)
The file was modifiedsrc/Ring-Core/RGStampParser.class.st (diff)
The file was modifiedsrc/Fuel-Tests-Core/FLHashedCollectionSerializationTest.class.st (diff)
The file was modifiedsrc/Rubric/RubTextStopConditions.class.st (diff)
The file was modifiedsrc/Metacello-Base/Metacello.class.st (diff)
The file was modifiedsrc/Ring-Definitions-Core/RGElementDefinition.class.st (diff)
The file was modifiedsrc/Compression/CompiledMethodTrailer.extension.st (diff)
The file was modifiedsrc/Compression/GZipReadStream.class.st (diff)
The file was modifiedsrc/System-Support/VirtualMachine.class.st (diff)
The file was modifiedsrc/Kernel-Tests/FloatTest.class.st (diff)
The file was modifiedsrc/Collections-Atomic-Tests/FIFOQueueTest.class.st (diff)
The file was modifiedsrc/HelpSystem-Core/HelpHowToHelpTopics.class.st (diff)
The file was modifiedsrc/MonticelloRemoteRepositories/MCSmalltalkhubRepository.class.st (diff)
The file was modifiedsrc/Collections-Unordered-Tests/DictionaryTest.class.st (diff)
The file was modifiedsrc/Glamour-Helpers/BlockClosure.extension.st (diff)
The file was modifiedsrc/FileSystem-Disk/DiskStore.class.st (diff)
The file was modifiedsrc/Graphics-Display Objects/Form.class.st (diff)
The file was modifiedsrc/Network-Kernel/NetNameResolver.class.st (diff)
The file was modifiedsrc/Compression/ZipFileMember.class.st (diff)
The file was modifiedsrc/Kernel-Chronology-Extras/Integer.extension.st (diff)
The file was modifiedsrc/Morphic-Widgets-Basic/PluggableButtonMorph.class.st (diff)
The file was modifiedsrc/System-Support/SmalltalkImage.class.st (diff)
The file was modifiedsrc/Collections-Atomic-Tests/LIFOQueueTest.class.st (diff)
The file was modifiedsrc/Kernel-Chronology-Extras/DateAndTime.extension.st (diff)
The file was modifiedsrc/Kernel/Float.class.st (diff)
The file was modifiedsrc/Kernel/Timespan.class.st (diff)
The file was modifiedsrc/Collections-Tests/SharedQueueTest.class.st (diff)
The file was modifiedsrc/Kernel/DateAndTime.class.st (diff)
The file was modifiedsrc/Files/AsyncFile.class.st (diff)
Commit 06e021784f8d24d0847b464392def9e33ceb2634 by marcus.denker
make sure to access literals with #literalAt: and skip the
#literalsToSkip at the end
The file was modifiedsrc/Kernel/CompiledCode.class.st (diff)
The file was modifiedsrc/Kernel/CompiledCode.class.st (diff)
The file was modifiedsrc/Kernel/CompiledCode.class.st (diff)
Commit 019613562736d61eb8500f157140db5cb435c6d0 by marcus.denker
do not change #sameLiteralsAs:
The file was modifiedsrc/Kernel/CompiledCode.class.st (diff)
Commit 00ecd96b246780ba588733c2d40d700dbe1924e7 by marcus.denker
- fix some tiny mistakes of the last PRs - rename declaringNode to
definingNode - implement isDefinition in terms of definingNode - add
#instanceVariables to Behavior returning Slots - remove #isSlot
introduces in the Variable hierarhchy (we have isInstanceVariable) -
remove #isObservable: Slot users should not add extension method if it
an be avoided
The file was removedsrc/VariablesLibrary/Slot.extension.st
The file was modifiedsrc/OpalCompiler-Core/ArgumentVariable.class.st (diff)
The file was modifiedsrc/Kernel/Variable.class.st (diff)
The file was modifiedsrc/Calypso-SystemTools-Core/ClySourceCodeContext.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/TemporaryVariable.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/LocalVariable.class.st (diff)
The file was modifiedsrc/AST-Core/RBProgramNode.class.st (diff)
The file was modifiedsrc/Kernel/Behavior.class.st (diff)
The file was modifiedsrc/AST-Core/RBVariableNode.class.st (diff)
The file was modifiedsrc/VariablesLibrary/TObservable.trait.st (diff)
The file was modifiedsrc/Slot-Tests/ArgumentVariableTest.class.st (diff)
The file was modifiedsrc/Calypso-Ring/RGMethod.extension.st (diff)
The file was modifiedsrc/OpalCompiler-Core/RBVariableNode.extension.st (diff)
The file was modifiedsrc/Slot-Tests/TemporaryVariableTest.class.st (diff)
The file was modifiedsrc/System-Support/Class.extension.st (diff)
The file was modifiedsrc/Kernel/Slot.class.st (diff)
The file was modifiedsrc/VariablesLibrary/ObservableSlot.class.st (diff)
Commit 161ae96e2db055ce532a831e63354ee0372409e9 by marcus.denker
isInstanceVariable instead of twice isLiteralVariable
The file was modifiedsrc/Calypso-SystemTools-Core/ClySourceCodeContext.class.st (diff)
Commit d572f23f38d496d87e5fc8042905f885379e846b by marcus.denker
- remove classAdded: on the instance side: dead code - implement enabled
and enabled: on RBLintRule - clean up all the code that just was there
because of these methods not implemenented
The file was modifiedsrc/Refactoring-Critics/RBLintRule.class.st (diff)
The file was modifiedsrc/Renraku/ReRuleManager.class.st (diff)
The file was modifiedsrc/Renraku/ReImageRuleBaner.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/LocalVariable.class.st (diff)
The file was modifiedsrc/GeneralRules-Tests/ReSuperWithoutSendTest.class.st (diff)
Commit 4d6fda9e217010d914be898459c3bdd4a0488235 by marcus.denker
ReReferencesObsoleteClassRule, fix ReGlobalVariablesUsageRule as it was
wrongly detecting
The file was modifiedsrc/GeneralRules/ReGlobalVariablesUsageRule.class.st (diff)
The file was addedsrc/GeneralRules/ReReferencesObsoleteClassRule.class.st
Commit cac870f8032602ffdeb237bea51177f2ff968a0b by marcus.denker
isGlobalClassNameBinding needs to return true for obsolete classes...
because they are classes
The file was modifiedsrc/Kernel/LiteralVariable.class.st (diff)
The file was modifiedsrc/GeneralRules/ReReferencesObsoleteClassRule.class.st (diff)
The file was modifiedsrc/GeneralRules/ReGlobalVariablesUsageRule.class.st (diff)
Commit 84ac45de740f3ab867eae1886d031a521f54d100 by marcus.denker
ReGlobalVariablesUsageRule : switch around test
The file was modifiedsrc/GeneralRules/ReGlobalVariablesUsageRule.class.st (diff)
Commit 9531aabfc50a3144aca3dc424ee90d5230dbb95d by marcus.denker
reduce references to RBVariableNode subclasses
The AST should only know variables. Givign meaning to it is done by
semantic analysis.
The file was modifiedsrc/Reflectivity/RFNewValueReification.class.st (diff)
The file was modifiedsrc/Reflectivity/RFReceiverReification.class.st (diff)
The file was modifiedsrc/OpalCompiler-Tests/OCVariableSpecialisationTest.class.st (diff)
The file was modifiedsrc/Reflectivity/RFOperationReification.class.st (diff)
The file was modifiedsrc/Calypso-SystemPlugins-Reflectivity-Browser-Tests/ClyInstallMetaLinkPresenterTest.class.st (diff)
The file was modifiedsrc/Reflectivity/RFMethodToExecuteReification.class.st (diff)
The file was modifiedsrc/Reflectivity/RFArgumentsReification.class.st (diff)
The file was modifiedsrc/AST-Core-Tests/RBDumpVisitorTest.class.st (diff)
The file was modifiedsrc/Reflectivity/RFValueReification.class.st (diff)