Changes

Summary

  1. Fix equals method: check against anObject (details)
  2. remove a pattern from the rule that does not make sense according to the (details)
  3. Do not instantiate a new WorldState, fixes #7089 (details)
  4. there is sime commented code (by false ifTtrue:) that we do not need (details)
  5. Context>>#lookupSymbol: is not well named... the name implies that it (details)
  6. fix more users (details)
Commit 10c7cebbc8abacef32c9898aec46d2544b9be589 by github
Fix equals method: check against anObject
The #= method did inadvertently check the instance variable #mergedParts
against itself instead of anObject's value for that instance variable.
The file was modifiedsrc/Calypso-SystemQueries/ClyMergedHierarchy.class.st (diff)
Commit cc51c9b6d211ead7c8cdc885840be5ee5b77e4cd by marcus.denker
remove a pattern from the rule that does not make sense according to the
description of the rule. (It makes sense, but we need to add this as
it's own rule wit the correct explanation). fixes #7096
The file was modifiedsrc/GeneralRules/ReConsistencyCheckRule.class.st (diff)
Commit 58d26ee4c050bf3cff43e42343eeff71c649aa6d by marcus.denker
Do not instantiate a new WorldState, fixes #7089
The file was modifiedsrc/Morphic-Widgets-Menubar/MenubarMorph.class.st (diff)
Commit 6614e16faed71b8390dc490c3b8a50f9c8e3cb22 by marcus.denker
there is sime commented code (by false ifTtrue:) that we do not need
anymore
The file was modifiedsrc/Kernel/FullBlockClosure.class.st (diff)
Commit ff6b69788ef6d1dfd5c566606d3b5b7bb3bd81f7 by marcus.denker
Context>>#lookupSymbol: is not well named... the name implies that it
would do somehting similar as lookupVar:, but it actually reads the
variable content. - add #readVariableNamed: - fix the users (just in
testss) of #lookupSymbol: to use #readVariableNamed: - simplify
#tempNamed: put:
The file was modifiedsrc/Kernel-Tests-Extended/ContextTest.extension.st (diff)
The file was addedsrc/Deprecated90/Context.extension.st
The file was modifiedsrc/Debugging-Core/Context.extension.st (diff)
The file was modifiedsrc/Debugger-Model-Tests/DebugSessionContextsTest.class.st (diff)
The file was modifiedsrc/Calypso-SystemPlugins-Reflectivity-Browser-Tests/ClyAddConditionalBreakpointCommandTest.class.st (diff)
The file was modifiedsrc/Calypso-SystemPlugins-Reflectivity-Browser/ClyAddConditionalBreakpointCommand.class.st (diff)

Summary

  1. Fix equals method: check against anObject (details)
  2. remove a pattern from the rule that does not make sense according to the (details)
  3. Do not instantiate a new WorldState, fixes #7089 (details)
  4. there is sime commented code (by false ifTtrue:) that we do not need (details)
  5. Context>>#lookupSymbol: is not well named... the name implies that it (details)
  6. fix more users (details)
Commit 10c7cebbc8abacef32c9898aec46d2544b9be589 by github
Fix equals method: check against anObject
The #= method did inadvertently check the instance variable #mergedParts
against itself instead of anObject's value for that instance variable.
The file was modifiedsrc/Calypso-SystemQueries/ClyMergedHierarchy.class.st (diff)
Commit cc51c9b6d211ead7c8cdc885840be5ee5b77e4cd by marcus.denker
remove a pattern from the rule that does not make sense according to the
description of the rule. (It makes sense, but we need to add this as
it's own rule wit the correct explanation). fixes #7096
The file was modifiedsrc/GeneralRules/ReConsistencyCheckRule.class.st (diff)
Commit 58d26ee4c050bf3cff43e42343eeff71c649aa6d by marcus.denker
Do not instantiate a new WorldState, fixes #7089
The file was modifiedsrc/Morphic-Widgets-Menubar/MenubarMorph.class.st (diff)
Commit 6614e16faed71b8390dc490c3b8a50f9c8e3cb22 by marcus.denker
there is sime commented code (by false ifTtrue:) that we do not need
anymore
The file was modifiedsrc/Kernel/FullBlockClosure.class.st (diff)
Commit ff6b69788ef6d1dfd5c566606d3b5b7bb3bd81f7 by marcus.denker
Context>>#lookupSymbol: is not well named... the name implies that it
would do somehting similar as lookupVar:, but it actually reads the
variable content. - add #readVariableNamed: - fix the users (just in
testss) of #lookupSymbol: to use #readVariableNamed: - simplify
#tempNamed: put:
The file was modifiedsrc/Debugging-Core/Context.extension.st (diff)
The file was modifiedsrc/Kernel-Tests-Extended/ContextTest.extension.st (diff)
The file was modifiedsrc/Debugger-Model-Tests/DebugSessionContextsTest.class.st (diff)
The file was addedsrc/Deprecated90/Context.extension.st
The file was modifiedsrc/Calypso-SystemPlugins-Reflectivity-Browser-Tests/ClyAddConditionalBreakpointCommandTest.class.st (diff)
The file was modifiedsrc/Calypso-SystemPlugins-Reflectivity-Browser/ClyAddConditionalBreakpointCommand.class.st (diff)