Changes

Summary

  1. this fixes #7153 by using the cached pragmas in #allSystemPragmas (details)
  2. PragmaType is from Spotter but hat no users --> remove (details)
  3. refactor some of the usres of PragmaCollector to use Pragma allNamed: instead (details)
  4. add two more forwarding method... they are used when scanning the whole system for self and thisContext (which is a bit slow thus I am hesitent to add tests) (details)
  5. Another small cleanup related to RemoteString: (details)
  6. Fix restart. With tests. (details)
Commit a53ad0f6d70767c2c7a3f0053547aab0852bcc22 by marcus.denker
this fixes #7153 by using the cached pragmas in #allSystemPragmas

This PR just does the trivial change, we can later clean up more (e.g. allSystemPragmas senders can use Pragma allInstalled directly)
The file was modifiedsrc/PragmaCollector/PragmaCollector.class.st (diff)
Commit 2240f1952f1add27dcfe2abda4921d6e30984511 by marcus.denker
PragmaType is from Spotter but hat no users --> remove
The file was removedsrc/GT-SpotterExtensions-Core/PragmaType.class.st
Commit 6150452edbdac3f6fc4ac05db5c2f3e470c2d75b by marcus.denker
refactor some of the usres of PragmaCollector to use Pragma allNamed: instead

There is more to be done, I would have fixed all but some of the rest are in "externally managed packages"...
The file was modifiedsrc/GT-Inspector/GTInspectorTagFilter.class.st (diff)
The file was modifiedsrc/System-Settings-Browser/SettingBrowser.class.st (diff)
The file was modifiedsrc/Clap-Core/ClapContext.class.st (diff)
The file was modifiedsrc/GT-Inspector/GTInspectorMethodListFilter.class.st (diff)
The file was modifiedsrc/System-Announcements/SystemAnnouncer.class.st (diff)
The file was modifiedsrc/System-FileRegistry/FileServices.class.st (diff)
The file was modifiedsrc/UnifiedFFI/FFICompilerPlugin.class.st (diff)
Commit da1d09641416736f1711125126cc9eb86b96ed24 by marcus.denker
add two more forwarding method... they are used when scanning the whole system for self and thisContext (which is a bit slow thus I am hesitent to add tests)
The file was modifiedsrc/Kernel/CleanBlockClosure.class.st (diff)
Commit 47e2295da70e3eb0fe064ff9bdd6ec64d5d595e2 by marcus.denker
Another small cleanup related to RemoteString:

ClassOrganization
- simplify #comment
- #commentStamp - use commentSourcePointer, not commentRemoteString
- #hasComment -> use commentSourcePointer, , not commentRemoteString
- remove #commentRemoteString

Ring: #asHistorical can be much simpler accessing sourcePointer instead of remote string

PharoChangesCondenser
- implement #commentRemoteStringFor: so we do not need to expose commentRemoteString in the API of the class organizer

The file was modifiedsrc/Ring-Definitions-Core/RGCommentDefinition.class.st (diff)
The file was modifiedsrc/System-SourcesCondenser/PharoChangesCondenser.class.st (diff)
The file was modifiedsrc/System-SourcesCondenser/PharoSourcesCondenser.class.st (diff)
The file was modifiedsrc/Kernel/ClassOrganization.class.st (diff)
The file was removedsrc/System-Sources/Object.extension.st
The file was modifiedsrc/System-Sources/RemoteString.class.st (diff)
Commit f7ea8375ba37554ba78bc6eb1b5e0f0098db0fe1 by guillermopolito
Fix restart. With tests.
Restarting a test re-executes the setup to refresh the execution context.
However, this is pushing old values in the operand stack before re-executing the setup, mixing old and new values and causing strange errors.
Re-executing the setup before restarting fixes it.
The file was modifiedsrc/Debugger-Model-Tests/RestartTest.class.st (diff)
The file was modifiedsrc/Debugger-Model-Tests/DebuggerTest.class.st (diff)
The file was modifiedsrc/Debugger-Model/DebugSession.class.st (diff)
The file was addedsrc/Debugger-Model-Tests/DebuggerTestCaseForRestartTest.class.st