Changes

Summary

  1. - Forward all checks #isSelf and friends to the Variable, never check the name (details)
  2. - It seems there is some confusion about #visitArgumentNode:...  for now change it to visitTemporaryNode: (details)
  3. fix decompiler (details)
  4. - remove RBVariableNode subclasses from #selfNode, #superNode and #thisContextNode (details)
  5. Fix DumpVisitorTests. (details)
  6. - remove #adaptToSemanticNode (details)
  7. small cleanup (details)
  8. - with #isTestMethod we can simplify TestCase>>#methodChanged: (details)
  9. when doing #cleanUpMethod, do (details)
  10. We can just implement the method and do what the deprecation explanation describes. fixes #7301 (details)
Commit 90c4f62edeb547f581c6c0c860069a0747fb62bc by marcus.denker
- Forward all checks #isSelf and friends to the Variable, never check the name
- Visitor forwards to the Variable, too.

TODO:
- #selfNode and superNode need to not use RBVariableNode subclasses
The file was modifiedsrc/Reflectivity/RFClassReification.class.st (diff)
The file was modifiedsrc/AST-Core/RBSuperNode.class.st (diff)
The file was modifiedsrc/HeuristicCompletion-Model/CoASTResultSetBuilder.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/SelfVariable.class.st (diff)
The file was modifiedsrc/Deprecated90/OCSelfVariable.class.st (diff)
The file was modifiedsrc/Kernel/Variable.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/ArgumentVariable.class.st (diff)
The file was modifiedsrc/AST-Core-Tests/RBParserTest.class.st (diff)
The file was modifiedsrc/Reflectivity/RFReceiverReification.class.st (diff)
The file was modifiedsrc/Reflectivity/RFValueReification.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/OCASTClosureAnalyzer.class.st (diff)
The file was modifiedsrc/HeuristicCompletion-Tests/CoSuperMessageHeuristicTest.class.st (diff)
The file was modifiedsrc/AST-Core-Tests/RBDumpVisitorTest.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/ThisContextVariable.class.st (diff)
The file was modifiedsrc/Reflectivity/RFSenderReification.class.st (diff)
The file was modifiedsrc/AST-Core-Tests/ASTEvaluationTest.class.st (diff)
The file was modifiedsrc/Deprecated90/OCLiteralVariable.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/SuperVariable.class.st (diff)
The file was modifiedsrc/Reflectivity/RFObjectReification.class.st (diff)
The file was modifiedsrc/Kernel/Slot.class.st (diff)
The file was modifiedsrc/Deprecated90/OCThisContextVariable.class.st (diff)
The file was modifiedsrc/Deprecated90/OCSuperVariable.class.st (diff)
The file was modifiedsrc/Deprecated90/OCSlotVariable.class.st (diff)
The file was modifiedsrc/Calypso-SystemPlugins-Reflectivity-Browser/ClyAddConditionalBreakpointCommand.class.st (diff)
The file was modifiedsrc/HeuristicCompletion-Tests/CoASTResultSetBuilderTest.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/TemporaryVariable.class.st (diff)
The file was modifiedsrc/AST-Core/RBVariableNode.class.st (diff)
The file was modifiedsrc/AST-Core/RBTemporaryNode.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/CopiedLocalVariable.class.st (diff)
The file was modifiedsrc/AST-Core/RBSelfNode.class.st (diff)
The file was modifiedsrc/Kernel/GlobalVariable.class.st (diff)
Commit 6d3bebd288fe303774f9fa94828acae454fc2e26 by marcus.denker
- It seems there is some confusion about #visitArgumentNode:...  for now change it to visitTemporaryNode:
- enable visitor
The file was modifiedsrc/OpalCompiler-Core/TemporaryVariable.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/ArgumentVariable.class.st (diff)
The file was modifiedsrc/Kernel/GlobalVariable.class.st (diff)
The file was modifiedsrc/AST-Core/RBVariableNode.class.st (diff)
The file was modifiedsrc/Flashback-Decompiler/FBDASTBuilder.class.st (diff)
Commit 0655794091c9db03095cb6fe2969db98d04c82e9 by marcus.denker
- remove RBVariableNode subclasses from #selfNode, #superNode and #thisContextNode
- fix failing tests in Refactoring-Tests-Core
- fix failing Ring test
The file was modifiedsrc/Refactoring-Core/RBRefactoryTyper.class.st (diff)
The file was modifiedsrc/Ring-Core/RGVariable.class.st (diff)
The file was modifiedsrc/Ring-Core/RGSlot.class.st (diff)
The file was modifiedsrc/AST-Core/RBVariableNode.class.st (diff)
The file was modifiedsrc/AST-Core-Tests/RBDumpVisitorTest.class.st (diff)
Commit f063f760e802e0204f29e67ec62b603c93f25e57 by marcus.denker
- remove #adaptToSemanticNode
- fix completion of arguments
The file was modifiedsrc/AST-Core/RBArgumentNode.class.st (diff)
The file was modifiedsrc/AST-Core/RBParseErrorNode.class.st (diff)
The file was modifiedsrc/HeuristicCompletion-Model/CoASTResultSetBuilder.class.st (diff)
The file was modifiedsrc/AST-Core/RBVariableNode.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/OCASTClosureAnalyzer.class.st (diff)
The file was modifiedsrc/OpalCompiler-Core/OCASTSemanticCleaner.class.st (diff)
Commit 55ccb58498e4db13b35c889d4368ba39489c3884 by marcus.denker
- with #isTestMethod we can simplify TestCase>>#methodChanged:
- class side initialize should not call super initialize
The file was modifiedsrc/SUnit-Core/TestCase.class.st (diff)
Commit e510ee61ba8593315d9842249e531a4792e2fb4b by marcus.denker
when doing #cleanUpMethod, do

MenubarMorph reset.
ToolRegistry allSubInstances do: [:each | each resetAnnouncer].

this reduces the number of CompiledMethod instances handing around after a recompile.
More needs to be done, I will open a new issue for that.

fixes #7059
The file was modifiedsrc/Tool-ImageCleaner/ImageCleaner.class.st (diff)
The file was modifiedsrc/Tool-Registry/ToolRegistry.class.st (diff)
Commit 453e31e777a374186ae6be3f9f70f01dfb308416 by marcus.denker
We can just implement the method and do what the deprecation explanation describes. fixes #7301
The file was modifiedsrc/AST-Core/RBComment.class.st (diff)