Changes

Summary

  1. - Move text insertion to completion context (to decouple NEC from (details)
  2. Hide the usage of the editor in the context (details)
  3. Hiding usage of isWorkspace (details)
  4. Move text insertion closer to the engine. The context is morphic (details)
  5. CompletionContext does not need editor anymore (details)
  6. Rename insertCompletion: => replaceCompletionWith: It does not insert, (details)
  7. Add comment (details)
  8. Be able to set context class from the outside (details)
  9. Simplify insertion by using explicit replace API (details)
  10. Further simplification. Remove insertCommonPrefixOrSelected which works (details)
  11. Further simplification. Remove unused method. (details)
  12. Correct replacement interval for messages (details)
  13. Remove unused methods (details)
  14. Remove unused variable (details)
  15. Recategorization (details)
  16. Recover position. It is used to get a completion token in the AST... (details)
  17. Rename to make code easier to understand (details)
  18. Revert using node. Node gets desyncronized with actual completion token (details)
  19. Renames and comment (details)
  20. Split NEC core from Morphic specific support. Yet to decouple (details)
  21. Remove circular dependency between Completion engine and morphic (details)
  22. Fix baseline to specify NECMorphic package too (details)
  23. Hiding real dependency from dependency analyzer to make tests pass. (details)
  24. Recover class comment (details)
Commit a52462a1b79601a8e48d3edd397ef26ea726836e by guillermopolito
- Move text insertion to completion context (to decouple NEC from
morphic a bit more) - Move decision of what to do with entry to entry
(and so have different kind of entries)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/NECMenuMorph.class.st (diff)
Commit fd772d3523a047fd3eceab6d365bc1ddc180d4c3 by guillermopolito
Hide the usage of the editor in the context
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit b4d50104e71eb6b6e556568930b9101d251a3218 by guillermopolito
Hiding usage of isWorkspace
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit c9354c211a8a8b02b219b2218ceea955dd226285 by guillermopolito
Move text insertion closer to the engine. The context is morphic
agnostic
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
Commit fdfe7d999a3532d11d1e97254891cae5b2ca1a90 by guillermopolito
CompletionContext does not need editor anymore
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit 39e594631e1a5e51af006d90a597de0d4e520b09 by guillermopolito
Rename insertCompletion: => replaceCompletionWith: It does not insert,
it replaces the partially typed token by the selected one.
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
The file was modifiedsrc/NECompletion/NECMenuMorph.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
Commit 54abc4e8d6f8c693afdf9f268ed861ffa23d9226 by guillermopolito
Be able to set context class from the outside
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
Commit 1c1909f789372113652d6d69246e020bce084daa by guillermopolito
Simplify insertion by using explicit replace API
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
Commit a78cc9062ef4192629168d503f568ec632865380 by guillermopolito
Further simplification. Remove insertCommonPrefixOrSelected which works
funny    - it inserts a common prefix  only if all candidates have a
common prefix (super rare situation)    - otherwise it inserts full
entry, as if the setting was false    => almost all of the times (i've
not found a case where it is not) it is as the setting is false Remove
the setting too
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/NECPreferences.class.st (diff)
The file was modifiedsrc/NECompletion/NECMenuMorph.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
Commit 117ff54e39221a03532a60e9623ed57082061f2e by guillermopolito
Further simplification. Remove unused method.
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
Commit c562ec9ccc5ffdb2d69e1e8109a3002027d23162 by guillermopolito
Correct replacement interval for messages
The file was modifiedsrc/NECompletion/NECSymbolEntry.class.st (diff)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit f17178fe6135752d2fc2c32ae6dfeb7e406a848b by guillermopolito
Recover position. It is used to get a completion token in the AST...
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit 8e28ef2d0d32758302b3ca0ad9bb21deebca44f9 by guillermopolito
Rename to make code easier to understand
The file was modifiedsrc/NECompletion/NECMenuMorph.class.st (diff)
Commit cf7e1398bbef473daa1abd942f9aa284bb2b4fd9 by guillermopolito
Revert using node. Node gets desyncronized with actual completion token
and its position may have shifted
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/NECSymbolEntry.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
Commit 471296ac90a58a3ce370ea5190b7db192afd98fc by guillermopolito
Split NEC core from Morphic specific support. Yet to decouple
preferences
The file was addedsrc/NECompletion-Morphic/package.st
The file was removedsrc/NECompletion/NECDetailMorph.class.st
The file was removedsrc/NECompletion/NECMenuMorph.class.st
The file was addedsrc/NECompletion-Morphic/NECDetailMorph.class.st
The file was addedsrc/NECompletion-Morphic/CompletionEngine.class.st
The file was modifiedsrc/NECompletion/NECPreferences.class.st (diff)
The file was addedsrc/NECompletion-Morphic/NECMenuMorph.class.st
The file was removedsrc/NECompletion/CompletionEngine.class.st
Commit 7e9e19eb9509b807b9777f7aab553925d28e4f0b by guillermopolito
Remove circular dependency between Completion engine and morphic
specific part.
The file was modifiedsrc/NECompletion-Morphic/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/NECPreferences.class.st (diff)
The file was addedsrc/NECompletion/ManifestNECompletion.class.st
The file was addedsrc/NECompletion/AbstractCompletionEngine.class.st
Commit ed24f81143f854ef61c64c35fd431fed369d968d by guillermopolito
Fix baseline to specify NECMorphic package too
The file was modifiedsrc/BaselineOfBasicTools/BaselineOfBasicTools.class.st (diff)
Commit 5b0402b22597dd129a07a0e4928caf83e8c25927 by guillermopolito
Hiding real dependency from dependency analyzer to make tests pass.
The file was modifiedsrc/NECompletion/ManifestNECompletion.class.st (diff)
The file was modifiedsrc/NECompletion/AbstractCompletionEngine.class.st (diff)

Summary

  1. - Move text insertion to completion context (to decouple NEC from (details)
  2. Hide the usage of the editor in the context (details)
  3. Hiding usage of isWorkspace (details)
  4. Move text insertion closer to the engine. The context is morphic (details)
  5. CompletionContext does not need editor anymore (details)
  6. Rename insertCompletion: => replaceCompletionWith: It does not insert, (details)
  7. Add comment (details)
  8. Be able to set context class from the outside (details)
  9. Simplify insertion by using explicit replace API (details)
  10. Further simplification. Remove insertCommonPrefixOrSelected which works (details)
  11. Further simplification. Remove unused method. (details)
  12. Correct replacement interval for messages (details)
  13. Remove unused methods (details)
  14. Remove unused variable (details)
  15. Recategorization (details)
  16. Recover position. It is used to get a completion token in the AST... (details)
  17. Rename to make code easier to understand (details)
  18. Revert using node. Node gets desyncronized with actual completion token (details)
  19. Renames and comment (details)
  20. Split NEC core from Morphic specific support. Yet to decouple (details)
  21. Remove circular dependency between Completion engine and morphic (details)
  22. Fix baseline to specify NECMorphic package too (details)
  23. Hiding real dependency from dependency analyzer to make tests pass. (details)
  24. Recover class comment (details)
Commit a52462a1b79601a8e48d3edd397ef26ea726836e by guillermopolito
- Move text insertion to completion context (to decouple NEC from
morphic a bit more) - Move decision of what to do with entry to entry
(and so have different kind of entries)
The file was modifiedsrc/NECompletion/NECMenuMorph.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
Commit fd772d3523a047fd3eceab6d365bc1ddc180d4c3 by guillermopolito
Hide the usage of the editor in the context
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit b4d50104e71eb6b6e556568930b9101d251a3218 by guillermopolito
Hiding usage of isWorkspace
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit c9354c211a8a8b02b219b2218ceea955dd226285 by guillermopolito
Move text insertion closer to the engine. The context is morphic
agnostic
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit fdfe7d999a3532d11d1e97254891cae5b2ca1a90 by guillermopolito
CompletionContext does not need editor anymore
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit 39e594631e1a5e51af006d90a597de0d4e520b09 by guillermopolito
Rename insertCompletion: => replaceCompletionWith: It does not insert,
it replaces the partially typed token by the selected one.
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
The file was modifiedsrc/NECompletion/NECMenuMorph.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
Commit 54abc4e8d6f8c693afdf9f268ed861ffa23d9226 by guillermopolito
Be able to set context class from the outside
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
Commit 1c1909f789372113652d6d69246e020bce084daa by guillermopolito
Simplify insertion by using explicit replace API
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
Commit a78cc9062ef4192629168d503f568ec632865380 by guillermopolito
Further simplification. Remove insertCommonPrefixOrSelected which works
funny    - it inserts a common prefix  only if all candidates have a
common prefix (super rare situation)    - otherwise it inserts full
entry, as if the setting was false    => almost all of the times (i've
not found a case where it is not) it is as the setting is false Remove
the setting too
The file was modifiedsrc/NECompletion/NECPreferences.class.st (diff)
The file was modifiedsrc/NECompletion/NECMenuMorph.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit 117ff54e39221a03532a60e9623ed57082061f2e by guillermopolito
Further simplification. Remove unused method.
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
Commit c562ec9ccc5ffdb2d69e1e8109a3002027d23162 by guillermopolito
Correct replacement interval for messages
The file was modifiedsrc/NECompletion/NECSymbolEntry.class.st (diff)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit f17178fe6135752d2fc2c32ae6dfeb7e406a848b by guillermopolito
Recover position. It is used to get a completion token in the AST...
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
Commit 8e28ef2d0d32758302b3ca0ad9bb21deebca44f9 by guillermopolito
Rename to make code easier to understand
The file was modifiedsrc/NECompletion/NECMenuMorph.class.st (diff)
Commit cf7e1398bbef473daa1abd942f9aa284bb2b4fd9 by guillermopolito
Revert using node. Node gets desyncronized with actual completion token
and its position may have shifted
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
The file was modifiedsrc/NECompletion/NECSymbolEntry.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionEngine.class.st (diff)
The file was modifiedsrc/NECompletion/CompletionContext.class.st (diff)
The file was modifiedsrc/NECompletion/NECEntry.class.st (diff)
Commit 471296ac90a58a3ce370ea5190b7db192afd98fc by guillermopolito
Split NEC core from Morphic specific support. Yet to decouple
preferences
The file was addedsrc/NECompletion-Morphic/NECMenuMorph.class.st
The file was addedsrc/NECompletion-Morphic/package.st
The file was removedsrc/NECompletion/CompletionEngine.class.st
The file was addedsrc/NECompletion-Morphic/NECDetailMorph.class.st
The file was addedsrc/NECompletion-Morphic/CompletionEngine.class.st
The file was removedsrc/NECompletion/NECMenuMorph.class.st
The file was modifiedsrc/NECompletion/NECPreferences.class.st (diff)
The file was removedsrc/NECompletion/NECDetailMorph.class.st
Commit 7e9e19eb9509b807b9777f7aab553925d28e4f0b by guillermopolito
Remove circular dependency between Completion engine and morphic
specific part.
The file was modifiedsrc/NECompletion/NECPreferences.class.st (diff)
The file was addedsrc/NECompletion/ManifestNECompletion.class.st
The file was addedsrc/NECompletion/AbstractCompletionEngine.class.st
The file was modifiedsrc/NECompletion-Morphic/CompletionEngine.class.st (diff)
Commit ed24f81143f854ef61c64c35fd431fed369d968d by guillermopolito
Fix baseline to specify NECMorphic package too
The file was modifiedsrc/BaselineOfBasicTools/BaselineOfBasicTools.class.st (diff)
Commit 5b0402b22597dd129a07a0e4928caf83e8c25927 by guillermopolito
Hiding real dependency from dependency analyzer to make tests pass.
The file was modifiedsrc/NECompletion/ManifestNECompletion.class.st (diff)
The file was modifiedsrc/NECompletion/AbstractCompletionEngine.class.st (diff)