Skip to content
[Jenkins]Jenkins
log in
Success

Changes

Summary

  1. add a testcase for 'with type <lhs> = <rhs>' scoping (commit: 45248a7) (details)
  2. Typemod.merge_constraint: be careful about the typing environments (commit: 7068266) (details)
  3. Typemod.merge_constraint: fix computation of the signature environment (commit: 8b2f64c) (details)
Commit 45248a7602d977a8e012ae9a1e37f8e3908ea915 by gabriel.scherer
add a testcase for 'with type <lhs> = <rhs>' scoping
 (commit: 45248a7)
The file was addedtestsuite/tests/typing-modules/merge_constraint.ml
Commit 7068266b32b9bb27d35af3cb881a6caa062f8672 by gabriel.scherer
Typemod.merge_constraint: be careful about the typing environments

This PR fixes an old bug in the interaction between [merge_constraint]
and [Typedecl.transl_with_constraint], where
variance (and now separability) are recomputed in an invalid type
environment. See #9624 and the new tests.
 (commit: 7068266)
The file was modifiedtestsuite/tests/typing-modules/merge_constraint.ml (diff)
The file was modifiedtyping/typemod.ml (diff)
The file was modifiedtyping/typedecl.mli (diff)
The file was modifiedChanges (diff)
The file was modifiedtyping/typedecl.ml (diff)
Commit 8b2f64c2ce121bc5b188a878447a87eb20f0a306 by gabriel.scherer
Typemod.merge_constraint: fix computation of the signature environment

(suggested by Leo White and Jacques Garrigue)
 (commit: 8b2f64c)
The file was modifiedtestsuite/tests/typing-sigsubst/sigsubst.ml (diff)
The file was modifiedtestsuite/tests/typing-modules/merge_constraint.ml (diff)
The file was modifiedtyping/typemod.ml (diff)