Skip to content
Success

Changes

Summary

  1. Refactor post_process of signature merging (commit: f9025a6) (details)
  2. Update comment and Changelog (commit: 706823f) (details)
  3. Address review comments (commit: b7a020f) (details)
  4. Update comment (commit: a4a7be5) (details)
Commit f9025a6d8644b69ccef173847a3d662210a023c4 by clement.blaudeau
Refactor post_process of signature merging

The [post_process] function for signature merging was taking two linked
arguments: a [~destructive] flag and a [replace] function to apply only if the
flag was set to [true]. This commit combines the two into a single optional
function [replace] and clarifies some documentation comments.
(commit: f9025a6)
The file was modifiedtyping/typemod.ml (diff)
The file was modifiedtyping/typemod.ml (diff)
The file was modifiedChanges (diff)
Commit b7a020fb50e677e793ddf50c74bf8e98611dbfae by clement.blaudeau
Address review comments

- Invert destructive and non-destructive cases
- Move the error inside the computation of the replace function
(commit: b7a020f)
The file was modifiedtyping/typemod.ml (diff)
The file was modifiedtyping/typemod.ml (diff)