Skip to content
In progress

Changes

Progress:

Summary

  1. Update parser and adapt to the new Tpoly invariant. Requires bootstrap. (commit: 94908d2) (details)
  2. bootstrap (commit: fbca0ab) (details)
  3. Add tests for polymorphic parameters (commit: a664599) (details)
  4. Promote polymorphic parameters tests failures (commit: c39e29d) (details)
  5. Refactor: more descriptive return type for [split_function], renaming and comment work (commit: 489e219) (details)
  6. Introduce new error "opt params cannot be polymorphic" (commit: da0cabe) (details)
  7. Wrap and generalize filter_arrow_mono if principal (commit: ba14d13) (details)
  8. Handle polymorphic parameters in type_apply_arg (commit: 24b6f4c) (details)
  9. Refactor Pexp_function case and handle poly (commit: 16d8e49) (details)
  10. Add one generalization level in type_class_arg_pattern (commit: e882d5a) (details)
  11. Handle polymorphic parameters in [type_approx and] [type_pat_aux] (commit: ac9691a) (details)
  12. Add changes entry for #15733 (commit: 6e02745) (details)
  13. Add test with class argument (commit: d31142a) (details)
  14. Additional tests with labels (commit: 2ad84dc) (details)
  15. review: reorder functions in btype (commit: f401ccf) (details)
  16. review: comment format (commit: ced4529) (details)
  17. review: add a Btype.newgenmono utility symetrical to Ctype.newmono (commit: b6629c6) (details)
  18. review: use label names in error messages (commit: 6fc24f4) (details)
  19. review: additional tests (commit: 2dd9b7d) (details)
  20. Add test for polymorphic variants in polymorphic parameters (commit: 669bd47) (details)
  21. Take fixed instances of polys where appropriate (commit: e93ba21) (details)
  22. Show issue with subtyping trace (commit: 74b9f1f) (details)
  23. Fix subtyping error trace (commit: 4e597e9) (details)
  24. tests: Promote error messages improvements after rebasing. (commit: e6d2834) (details)
  25. review: more reuse in parser and reloc in [param_type] (commit: be3016c) (details)
  26. review: move [is_really_poly] utility to Ctype. (commit: a5dc2ad) (details)
  27. Add more test cases (commit: 47350a7) (details)
  28. Move definition closer to usage (commit: 19c9abe) (details)
  29. Additional test cases (commit: c5587a4) (details)
  30. Document function in comment (commit: c9a8533) (details)
  31. Add test cases (commit: 21b3641) (details)
  32. Fix typo in error message (commit: 7cde513) (details)
  33. Rename function and move it to Btype (commit: e8eb592) (details)
  34. Inline function and exception used only once (commit: d01ee5f) (details)
  35. Document function (commit: 1dcf986) (details)
  36. Enforce Tpoly invariant (commit: 7d2f412) (details)
  37. Clarify conditions (commit: ad0db61) (details)
  38. Clearer argument label and field names (commit: 730e704) (details)
  39. Turn ordinary comment into a documentation comment (commit: ba7bf49) (details)
  40. Clearer variable name (commit: 1e1c51e) (details)
  41. Fix wrong set of univars (commit: 73934de) (details)
  42. review: De-duplicate parser rule for let (commit: 7202cde) (details)
  43. review: Add test with syntactic arity mismatch (commit: 6e7a744) (details)
  44. review: Fix test (commit: f3d08a2) (details)
Commit 94908d2051d08eedc7543cd0a0b0f811e5f7d6c4 by Florian Angeletti
Update parser and adapt to the new Tpoly invariant. Requires bootstrap.

The argument of a Tarrow must now be a [Tpoly] node.
(commit: 94908d2)
The file was modifiedtyping/out_type.ml (diff)
The file was modifiedtyping/btype.ml (diff)
The file was modifiedtyping/btype.mli (diff)
The file was modifiedparsing/parser.mly (diff)
The file was modifiedtyping/typedecl.ml (diff)
The file was modified.depend (diff)
The file was modifiedtoplevel/topprinters.ml (diff)
The file was modifiedtyping/typetexp.mli (diff)
The file was modifiedtestsuite/tests/typing-objects/Exemples.ml (diff)
The file was modifiedtyping/ctype.ml (diff)
The file was modifiedtyping/typeclass.ml (diff)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtyping/typeclass.mli (diff)
The file was modifiedboot/menhir/parser.ml (diff)
The file was modifiedtyping/ctype.mli (diff)
The file was modifiedtyping/types.mli (diff)
The file was modifiedtyping/typecore.mli (diff)
The file was modifiedtyping/errortrace_report.ml (diff)
The file was modifiedtyping/typeopt.ml (diff)
The file was modifiedtyping/typetexp.ml (diff)
The file was modifiedboot/ocamllex (diff)
The file was modifiedboot/ocamlc (diff)
Commit a6645993f8ee41156c4f619c49aa940d814975fa by Florian Angeletti
Add tests for polymorphic parameters
(commit: a664599)
The file was addedtestsuite/tests/typing-poly/poly_params.ml
Commit c39e29dd0f745998e48f4721b27daba04d1759d0 by Florian Angeletti
Promote polymorphic parameters tests failures
(commit: c39e29d)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
Commit 489e219fb95fa95a48ffa8a70e12995c98ede018 by Florian Angeletti
Refactor: more descriptive return type for [split_function], renaming and comment work
(commit: 489e219)
The file was modifiedtyping/typecore.ml (diff)
Commit da0cabe07b8e5ab2bc7c443350da798598888d52 by Florian Angeletti
Introduce new error "opt params cannot be polymorphic"
(commit: da0cabe)
The file was modifiedtyping/typecore.mli (diff)
The file was modifiedtyping/typecore.ml (diff)
Commit ba14d13c046ebc74b9638a2ce79aef22a92d09bd by Florian Angeletti
Wrap and generalize filter_arrow_mono if principal
(commit: ba14d13)
The file was modifiedtyping/typecore.ml (diff)
Commit 24b6f4c4a5b05a19ec2aa3fd49d5d4ff69304493 by Florian Angeletti
Handle polymorphic parameters in type_apply_arg
(commit: 24b6f4c)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
Commit 16d8e49c786f0ebf885cebc54dfc288ee9d74ddc by Florian Angeletti
Refactor Pexp_function case and handle poly
(commit: 16d8e49)
The file was modifiedtyping/typecore.ml (diff)
Commit e882d5ae4248f26fba18b6ad9414ef997fd4903b by Florian Angeletti
Add one generalization level in type_class_arg_pattern
(commit: e882d5a)
The file was modifiedtyping/typecore.ml (diff)
Commit ac9691aca9a94f5a8c2aae37cf5fa9f2810a117f by Florian Angeletti
Handle polymorphic parameters in [type_approx and] [type_pat_aux]
(commit: ac9691a)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedlambda/translcore.ml (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
The file was modifiedChanges (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
Commit f401ccf8d0d0ad9a10b1cbd939d1bf64cea37f35 by Florian Angeletti
review: reorder functions in btype
(commit: f401ccf)
The file was modifiedtyping/btype.mli (diff)
The file was modifiedtyping/btype.ml (diff)
The file was modifiedtyping/types.mli (diff)
Commit b6629c6e715c565ca3b8d38fa4d36480342b23ec by Florian Angeletti
review: add a Btype.newgenmono utility symetrical to Ctype.newmono
(commit: b6629c6)
The file was modifiedtyping/typeclass.ml (diff)
The file was modifiedtyping/btype.mli (diff)
The file was modifiedtyping/btype.ml (diff)
Commit 6fc24f4eefbda7396884a4b76ba288a180ae7972 by Florian Angeletti
review: use label names in error messages
(commit: 6fc24f4)
The file was modifiedtyping/typetexp.mli (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtyping/typecore.mli (diff)
The file was modifiedtyping/typetexp.ml (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
Commit 669bd470115fbd04c3dd3b76c588c68a973adc56 by Florian Angeletti
Add test for polymorphic variants in polymorphic parameters
(commit: 669bd47)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
Commit e93ba211dbd022139cfc36e05e3d4e0185925fcd by Florian Angeletti
Take fixed instances of polys where appropriate

This fixes a bug in the interaction between polymorphic variants and polymorphic
parameters. The actual bug fix is just changing two falses to trues but I also
changed the instance_poly interface to make similar mistakes less likely to
happen.
(commit: e93ba21)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
The file was modifiedtyping/typeclass.ml (diff)
The file was modifiedtyping/ctype.ml (diff)
The file was modifiedtyping/ctype.mli (diff)
The file was modifiedtyping/typedecl.ml (diff)
The file was modifiedtestsuite/tests/typing-misc/typecore_errors.ml (diff)
The file was modifiedtyping/ctype.ml (diff)
The file was modifiedtestsuite/tests/typing-misc/typecore_errors.ml (diff)
The file was modifiedtestsuite/tests/typing-objects/Exemples.ml (diff)
Commit e6d2834a5dcef5ffa9337177182e09ec7f77e6a7 by Florian Angeletti
tests: Promote error messages improvements after rebasing.
(commit: e6d2834)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
Commit be3016c7e6c5ca9db647b3044f79e3e2fe2b441d by Florian Angeletti
review: more reuse in parser and reloc in [param_type]
(commit: be3016c)
The file was modifiedparsing/parser.mly (diff)
The file was modifiedboot/menhir/parser.ml (diff)
Commit a5dc2ad2083e7d08de84ed5144a7703f95588127 by Florian Angeletti
review: move [is_really_poly] utility to Ctype.
(commit: a5dc2ad)
The file was modifiedtyping/ctype.ml (diff)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtyping/ctype.mli (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
The file was modifiedtyping/btype.mli (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
The file was modifiedtyping/typeclass.ml (diff)
Commit e8eb592e3fa593ce78f73ce9282d96a56a06246f by Florian Angeletti
Rename function and move it to Btype
(commit: e8eb592)
The file was modifiedtyping/ctype.ml (diff)
The file was modifiedtyping/btype.mli (diff)
The file was modifiedtyping/btype.ml (diff)
The file was modifiedtyping/ctype.mli (diff)
The file was modifiedtoplevel/topprinters.ml (diff)
Commit d01ee5f4d04585414bbe9adf40654a367b970b23 by Florian Angeletti
Inline function and exception used only once
(commit: d01ee5f)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtyping/ctype.ml (diff)
The file was modifiedtyping/ctype.mli (diff)
The file was modifiedtyping/ctype.mli (diff)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtyping/typecore.ml (diff)
Commit 730e7044b3d77db58cde54614f2557a6e9932cf2 by Florian Angeletti
Clearer argument label and field names
(commit: 730e704)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtyping/ctype.ml (diff)
The file was modifiedtyping/ctype.mli (diff)
Commit ba7bf4906ff62d18be80de1382847c59b8226e31 by Florian Angeletti
Turn ordinary comment into a documentation comment
(commit: ba7bf49)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtyping/typecore.ml (diff)
The file was modifiedtyping/typecore.ml (diff)
Commit 7202cdef2c09882a930eeeffccb8902009d60323 by Florian Angeletti
review: De-duplicate parser rule for let
(commit: 7202cde)
The file was modifiedboot/menhir/parser.ml (diff)
The file was modifiedparsing/parser.mly (diff)
Commit 6e7a74424008a091e8c17ff187d129f95d5ee980 by Florian Angeletti
review: Add test with syntactic arity mismatch
(commit: 6e7a744)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)
The file was modifiedtestsuite/tests/typing-poly/poly_params.ml (diff)