Changes

Cleanup Shout 

- Remove #stylingEnabled: because this is never used and if we do not want to style a text, we should not give it to the styler
- Remove #text ivar that is unused
- Remove #plugins that are unused

Fixes #16310

add an environment variable to be able to specify the driver I want to run.

Just getting started

With more tests and ready

Tests for #####( and ####[

Start to simplify some rule tests

Second pass at simplifying tests

New cleaning pass

Simplify more tests

Improve ClassFactoryForTestCase cleanup

By default ClassFactoryForTestCase generates its classes in the same package and cleanup this package afterward. 
The problem is that a user can define its own package for the classes to create and those are not cleanup up.

I propose to improve the cleanup to remove those packages if they are empty.

Update the way to know what package to remove

FIx the package removal logic to work with custom environments

Improve FLBasicSerializationTest>>#testWideStringClassName

This test change the name of a class after creating it but this seems to create a problem that this class ends up been an obsolete class once we cleanup after the test.

To not let any leftover I propose to create it directly with the right name from the start. With this, no obsolete class stays in the system afterward

Branch: FixDuplicatePackageWhenNoStartingAcronym,  Fixes # 

Adding some tests

Branch: ShortcutDescriptions,  Fixes # 

revert conflictibg change

Fixing the RBRegexText into Test

New batch of rules simplification

Revert wrong changes

Simplify the last rules

Remove a usage of an old icon name

Icon names should not have "Form" as suffix anymore.

Show correct modifier for NEC item browsing on Linux/Win

Removed reference to the shortcuts browser from the settings. This was just a button inside the settings to open the shortcuts browser. An open button should not be in the settings

Fixed mistake made in commit 67de41552f0ce57b (“Differentiate Morph scale factor from […]”): no initialization was added for the instance variable ‘zoomFactor’ of WorldMorph, causing an error when opening an extra world due to the variable being nil.

Branch: EnhancedCoMock,  Fixes # 

Improve the selection color of the dark theme

It's hard to see in the world menu the text that is been hovered. Here is an improvement of the theme

Introduce the possibility to change the fetcher of the global variable

Forcing the addition of the instance variable package in CoMockClass

Branch: TurnOffUncloseWindow,  Fixes # 17820

Handled what happens if close shortcut

Converting to float before the operation makes it 1.5 times faster, and does not allocate a fraction.

Fix dependency test

We have a dependency test failing because Form has the method #asText that adds a TextAnchor attribute to a string. 
This TextAnchor is in Morphic but in fact it can also be used with forms instead of morphs. 

I'm proposing to move the attribute to Text-Core since it does not necessarily depend on Morphic and I also moved Form>>#asText to Text-Core.

This will fix the dependency test

Fix setting breakpoints

Followup on cleanings did on the compiler

Remove a few methods with equivalent in superclass

Fixes #17730 Message not understood issue

Branch: 17832-Transcript-vs-Smalltalk-tools-toolNamed-transcript,  Fixes #17832

Avoid-unnecessary-selector-clash-with-isPrimitiveError,  Fixes #17848

Fix dependency analyser double click on method item

Make all the presenter of Dependency analyser subclasses of StPresenter instead of SpPresenter. 
Solve the menu bug this way

Create a new package to place AST related functionality that are used by tools but not by the compiler. 
Since AST should be renamed OpalAST I named this new package OpalCompiler-ToolFeatures. 
May be in a second step we should move the classes to the package of their users renraku and rb 
but this is trickier for ParserTreeMatcher and ParseTreeRewriter.

MOving Dependency Analyzer after new Tools.

Push up #classInstaller

Sometimes we have random falilures because we ask a class installer to a metaclass. 
We can just push up #classInstaller because metaclasses have all the infos needed to give this class installer. This can fix some random failures we have

Improve error on File deletion failure

The file deletion failure uses the #name variable to give info on which file is been deleted. But the method is on the class side, so in reality it returns "File" all the time instead of the file name... On the CI I end up with this kind of failures: `Could not delete file File. Check the file is not open.`. 

I propose to update the error to use the path of the file instead to have a better log and have an easier time to debug things when we have test failures in the CI. 

Revert "Fix dependency analyser double click on method item"

Trying to change the default of DependencyAnalyser and loading it

Removing tab from default because of a dependency to calypso.
Strangely enough calypso is loaded before DA so no idea why it is not working

Trying to place the tab at the end of the baseline of Pharo.
		
	

Revert "Trying to change the default of DependencyAnalyser and loading it"

Use ShellExecuteW instead of ShellExecuteA for NativeBrowserOpenVisitor

This allows usage of the class for opening files that include non-ASCII characters in their filepaths.

Change windows-tabing shortcut (ctrl + tab)

Improve taskbar list management

Remove unused method

Testing TaskListMorph

Ups, missing instance variable

Using good shortcut name and category

REDO: Using good shortcut name and category

Revert "Removing the fact that ### equals #"

Fix the protocol of #setUp

Branch: CoStaticBenchmarksV2,  Adding the working version of CoStaticBenchmarks; all the maetrics ;with heuristcs ; with green tests

Improve the default comparision value

Do not use a random precision but use one that proved itself

This value is the default used by Polymath and comes from Numerical Recipes, 3rd edition, Section 5.7, which is pages 229-230

This is not for Pharo 11 but Pharo 12!


Do not use a random precision but use one that proved itself

This value is the default used by Polymath and comes from Numerical Recipes, 3rd edition, Section 5.7, which is pages 229-230

Better comments for Beacon

Improve precision of some assertions 

Improve comment

Fix #15183: Ineffective formatting does not update code editor

Fix equality check + Restore selection/Keep cursor at end, after formatting

Remove `aBoolean = true` checks in RubAbstractTextArea

Fix keeping cursor at end + Selection was already being restored

Branch: CoStaticBenchmarksV2,  Fixing a test + adding some comments in the benchs

Branch: CoStaticBenchmarksV2,  Fixing tests about the NDCG metric

Branch: CoStaticBenchmarksV2,  Another commit for fixing the NDCG tests

Adding a announcement to be able to monitor what the user picked in the completion menu

recategorising class

17895-Better-hook-for-completion-engine-in-RubSmalltalkTextEditor

Fixing the problem with CoCompletion

Adding a couple of tests.

OCFormatterTest cleaning. 
OCFormatterTest -> OCSimpleFormatterTest
OCParseTreeTest 

testTransform

Cleaning OCIRBuilderTest dependency to superclass.

Less formatted code

Move addNodeLast: to the package Refactoring-Transformations

Move addSelfReturn as extension

Move extractSubtreeWith:  as extension of Refactoring

Branch: adding-isValid-for-SDLWindows
Fixing the isValid for SDL2Windows and other handles

Rewrite testIsPrimitive

Move isEssential to Refactoring-Core

Cleaning OCArrayLiteralTest 

Better testLiteralVariableGlobale

Migrate testCase.

Remove generate method and unclassified one.

One more self contained reference

Removing useless pragma compilation methods

Much better OCSimpleFormatter tests. Less duplication more self contained. No we should not send formattedCode to Node!

Less spurious formattedCode. It does not make sense to ask the formatter to format just one variable!

Removing misplaced browing methods,  Fixes # 17396

Properly update the AST when the method editor gets its text changed

Currently we were only updating the AST when doing applying changes (see ClyMethodCodeEditorToolMorph>>#applyChanges).
This is not the only way the text may be changed (for example: a refactoring may also change it).
The other ways to update the text break the AST putting the method editor in a weird state where it shows the new code and does structural edits stuff using the old one.

An example of this issue can be experiencied by trying to do "extract temp" multiple times on the same method editor.

Reported-by: Andrzej Prochyra <andrzej@prochyra.io>

Fixes # 17891

Branch: Fix-Baseline-CoStaticBenchmarks,  Adding the `HeuristicCompletion-Benchmarks-Tests` to the baseline ( it was already there ) just we need the code that loads the package

Branch: Fix-Baseline-CoStaticBenchmarks,  Fixe the classification of message `run` in `CoStaticBenchmarksVariables`

Branch: fixIssue17908,  Fixes # 17908 use  string instead of an RBArgumentName

fixed #17568

I used accessing for now,  to be close to  #pc (and there are lots of methods that are not strict accessors already)

Fix issue #7908, fix method definition refactoring preconditions

Styling and simplifying

Fix #6528: do not skip closing characters
+ Remove unused `RubTextEditor>>#binlParenAt:`

Do not remove matching closing character when removing opening character literal

 17916-Adding-deprecated-binding-to-IR
Fixes #17916

Branch: 17225-Progress-Bar-in-Dark-Theme-does-not-have-a-good-contrast2,  Fixes #17225

IRBuilder -> OCIRBuilder in sampleBytecodeMethodWithArg:

Branch: Fix-Baseline-CoStaticBenchmarks,  Some modifications on the comments

Improve secondary selection color for light theme

Fixes #17920

Push up #removeFromTree

In multiple projects I'm doing AST manipulation (fro example in Famix or in my project Chanel) and I need to remove some nodes from an AST. Currently it's possible only on MessageNodes but this should be possible on much more nodes. 
I propose to push up this method on ProgramNodes 

Fix bug with obsolete classes and extension methods

If you recompile a class with extension methods and remove it afterward, then the class stays as obsolete. This happens because of a bug creating duplicated entries in the packages extension maps. 

I'm proposing a fix to not add new entries to the extension maps in case of recompilation. Coming with a comment and a regression test.

Fixes #17927

Branch: addInspectOnPackages,  Fixes #17911

Improve ReRefersToClassRule name

It is weird that the rules says to use `self class` when we are on the class side. I'm updating the rule name to show this possibility

Fixes #17123

[Foward port] RGGlobalVariable should be a RGVariable

Foward port of: https://github.com/pharo-project/pharo/pull/17470

Fixes #17511

Speedup Random initialization from seed

When setting the seed, this change avoid to have a double initialization of the seed to speed it up.

```st
{ [ Random new ]. [ Random seed: 7 ] } collect: #bench.

"
Before:
an Array(
4,527,035 iterations in 5 seconds 2 milliseconds.905044.982 per second
2,578,191 iterations in 5 seconds 3 milliseconds. 515329.003 per second)"

 "
After:
an Array(
4,839,828 iterations in 5 seconds 1 millisecond. 967772.046 per second
5,454,942 iterations in 5 seconds 2 milliseconds. 1090552.179 per second)"
```

Fixes #17510

Fix the logic of the extra commands on methods

In Calypso Hernan started to migrate commands from Commander1 to Commander2. This brought a change in the logic but the commands in the extra group on methods lost the ability to execute the #prepareFullExecution method which cause some commands to fail.

I'm fixing this + I renamed a class to have a better name

Fixes #17506

Added 2 metaclass variables to remember last text to find and last text used to replace

-Now when opening again find and replace, the previous texts are remembered, providing efficiency and gain of time for the user
-In most cases it was redundant to retype the texts, because often it is a repetition when using this tool

Remove the Transcript stepGlobal call. Better integrate it once the new transcript is on. 

Remove dependency analyser, moved to newtools

Rename dependency analyser classes

Remove ExternalProjectLoader

This class seems to be dead code? Probably used in the past for the bootstrap?

The class comment says it's to have versions tested with Pharo but the projects present inside do not seems to match. For example Roassal is in Pharo already and the repo in the #allProjects method is not the official repo anymore

Fix 8 Dictionary tests to make them inheritable
+ Implement ``SystemEnvironment>>#at:update:initial:` and adapt this class' tests

Add key type check in `SystemEnvironment>>#at:update:initial`
+ With a test similar to `testAtPutNil`
+ Fix typo in comment

Fixing dependency analyser opening

CleaningNautilusRefactoring
- first move extensions to their classes

- Remove from nautiluse and AbatsrctTransformation the question to search or not in the hierarchy when doing an extract method. 

- inline handleMethodNameRequest: since it got only one sender in the same class.

chore:
- remove dead code mapArguments: args toValues: values in: aTree
- remove then the class RBMethodArgumentsSelector since it was only called by mapArguments: args toValues: values in: aTree

chore: replace the only user of RBMethodEditor by StMethodEditorPresenter

chore: Remove unused RBMethodNameEditor

test: Adding tests for ClassesAreNotMetaclassCondition

feat: add message to ReClassesAreNotMetaclass for better feedback

test: Add two simple tests for messages

Better tests for movetoclasside (not changing its wrong semantics for now)

Renaming some temps for better understanding code. 

tests: define some tests for DefinesSelectorCondition

With metaclasses

Better name and accesspor for RBMoveMethodToClassRefactoring

Add choices for RemoveMethodsToClassSide Driver

Remove old driver and introduce new one with the new architecture

Branch: temp,  Fixes # changes

Remove ReIsNotAMetaclass and replace with ReClassesAreNotMetaClassCondition

Fix system dependency tests

By renaming the class to do the analysis

Should not implement `SystemEnvironment>>#at:update:initial:`

Clean BaselineOfClap

Remove references to packages and dependencies that are not in Pharo

Fixes #17366

Pharo13.0.0:
#Branch: misc/clean-baselineOfClap Fixes #
#Please use one of those
#feat:
#fix:
#refactor:
#chore:
#comment:

Move HashTesterTest to SUnit-Tests

Where it should be

Refactor OCMessageNode>>isInlineToDo to remove OCParseTreeSearcher

Remove some dead references to SmalltalkHub

Those methods are not used anymore

Format the code changes

Implemented new menu to show pool users

Branch: poolusers,  Fixes #17078

Pharo13.0.0:
#Branch: 17938-Emergency-Debugger-should-be-resiseable 
Fixes #17938

Emergency debugger should react to the resize of the window taking in account the scale factor and showing the last text again.

Pharo13.0.0:
#Branch: 17727-Fix-the-two-skipped-tests-in-DrTests Fixes #17727
- Removing skipped tests from DrTest. 
- Fixing the title holder to set it even if there is no window.

#Branch: 17903-Using-Windows-key--click-to-find-implementors-has-side-effects Fixes #17903
Using metaKeyPressed instead of commandKeyPressed

Fix testTranscriptDebugPoint to avoid using Transcript>>stepGlobal

Removed wrong comment in SourceFile Class

chore: Removing OldDeprecated Driver+ Refactoring + tests + commands

Pharo13.0.0:
#Branch: 17955-DeprecateClassRefactoring-should-be-removed-because-it-is-not-based-on-deprecatedAliases Fixes #
#Please use one of those
#feat:
#fix:
#refactor:
#chore:
#comment: