Skip to content
[Jenkins]Jenkins
log in
Success

Changes

Summary

  1. Make RBAbstractClass match the MOP answering both false by default in #isAbstract. (details)
  2. Update src/Refactoring-UI-Tests/ReMakeClassAbstractDriverTest.class.st (details)
  3. Update src/Refactoring-UI/RBMakeClassAbstractDriver.class.st (details)
  4. Use more readable name for unreferenced class, as suggested by @balsa-sarenac (details)
  5. Inform error string if runRefactoring fails. (details)
  6. Revert RBAbstractClass>>isAbstract to be true by default. (details)
  7. Use generateChanges: instead of execute (details)
  8. Changed #pharoItemsOn: for WorldState and #menuCommandOn: for ProfStef to use the icon #smallPharo instead of scaling the icon #pharo. (details)
Commit 3d5d31f2f031aa42ee096969a5f3865f3aed63ef by hernan.morales
Make RBAbstractClass match the MOP answering both false by default in #isAbstract.
Migrate RBMakeClassAbstractTransformation.
Add data for testing: #RBClassWithoutSelfClassReferenceTest and #RBWithSelfClassReferenceTest
Update RBMakeClassAbstractParametrizedTest
Add #RBMakeClassAbstractDriver with tests
Update #SycCMakeAbstractCommand
The file was modified src/Refactoring-Core/RBAbstractClass.class.st (diff)
The file was addedsrc/Refactoring-DataForTesting/RBWithSelfClassReferenceTest.class.st
The file was modified src/SystemCommands-ClassCommands/SycCMakeAbstractCommand.class.st (diff)
The file was modified src/Refactoring-Core/RBMakeClassAbstractTransformation.class.st (diff)
The file was modified src/Refactoring-Transformations-Tests/RBMakeClassAbstractParametrizedTest.class.st (diff)
The file was modified src/Refactoring-UI/RBInteractionDriver.class.st (diff)
The file was addedsrc/Refactoring-UI/RBMakeClassAbstractDriver.class.st
The file was addedsrc/Refactoring-DataForTesting/RBClassWithoutSelfClassReferenceTest.class.st
The file was modified src/Refactoring-Transformations-Tests/RBAbstractRefactoringTest.class.st (diff)
The file was addedsrc/Refactoring-UI-Tests/ReMakeClassAbstractDriverTest.class.st
Commit 441b49c33a76d06ab14f870eb49eced3b8785ef8 by github
Update src/Refactoring-UI-Tests/ReMakeClassAbstractDriverTest.class.st

Co-authored-by: balsa-sarenac <34557616+balsa-sarenac@users.noreply.github.com>
The file was modified src/Refactoring-UI-Tests/ReMakeClassAbstractDriverTest.class.st (diff)
Commit 15cb213fdf20e7a46ac63b9a395b1522396998ac by github
Update src/Refactoring-UI/RBMakeClassAbstractDriver.class.st

Nice one!

Co-authored-by: balsa-sarenac <34557616+balsa-sarenac@users.noreply.github.com>
The file was modified src/Refactoring-UI/RBMakeClassAbstractDriver.class.st (diff)
Commit e42dd0a8cc6d6807490ed5dd9816009d5cece44f by hernan.morales
Use more readable name for unreferenced class, as suggested by @balsa-sarenac
The file was modified src/Refactoring-Transformations-Tests/RBAbstractRefactoringTest.class.st (diff)
Commit 4a223e71a79caea88f5904a1c45869a1f81819cd by hernan.morales
Inform error string if runRefactoring fails.
The file was modified src/Refactoring-UI/RBMakeClassAbstractDriver.class.st (diff)
Commit 156405407bf689e2e2de8231273a0f9473af6b01 by hernan.morales
Revert RBAbstractClass>>isAbstract to be true by default.
Fix test
The file was modified src/Refactoring-UI-Tests/ReMakeClassAbstractDriverTest.class.st (diff)
The file was modified src/Refactoring-Core/RBAbstractClass.class.st (diff)
Commit 8d4a2d25074c879b16e24ca3f58dc623ed36cc44 by hernan.morales
Use generateChanges: instead of execute
The file was modified src/Refactoring-Core/RBMakeClassAbstractTransformation.class.st (diff)
Commit b3a4d06dfab2db5cd67af856f6ad38fbf0f39427 by 1611248+Rinzwind
Changed #pharoItemsOn: for WorldState and #menuCommandOn: for ProfStef to use the icon #smallPharo instead of scaling the icon #pharo.
The file was modified src/ProfStef-Core/ProfStef.class.st (diff)
The file was modified src/Morphic-Core/WorldState.class.st (diff)