SuccessChanges

Summary

  1. contrib/completions: install in $(datadir)/bash-completion/completions (details)
  2. contrib/completions: rename hwloc-completions.bash to bash/hwloc (details)
  3. core: cleanup the insertion by cpuset API and error reporting (details)
Commit f4253b4c246072264c423323050c48c1f1409ff1 by brice.goglin
contrib/completions: install in $(datadir)/bash-completion/completions

The old /etc/bash_completions.d/ is still available by
installing with something like:
  make install bashcompletionsdir='/etc/bash_completions.d

Thanks to Tomasz Kłoczko for the suggestion (see #413 for details)

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedcontrib/completion/Makefile.am (diff)
Commit 66a907cd5f8e75ca008f0e4618a602858f127c75 by brice.goglin
contrib/completions: rename hwloc-completions.bash to bash/hwloc

No need to have "-completion" in the name.

Remove the .bash suffix so that the install path is similar to others
(renaming isn't trivial in automake).

Move to a bash subdirectory in case we ever ship a zsh completion file.

Thanks to Tomasz Kłoczko for the suggestion (see #413)

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedNEWS (diff)
The file was removedcontrib/completion/hwloc-completion.bash
The file was addedcontrib/completion/bash/hwloc
The file was modifiedcontrib/completion/Makefile.am (diff)
Commit 0dce1af93d1abf701817d0593099d484f13859ca by brice.goglin
core: cleanup the insertion by cpuset API and error reporting

Our insert error reporting has never been very useful because
it uses __LINE__ from the error location, not from where the
caller performed the first insert call. Having a full backtrace
would solve this (see #223) but it doesn't work very well.

We now pass a "reason" string identifying the call point
(such as "linux:sysfs:package").
This removes the need for custom reporting error callbacks
(only used for distances groups anyway).

There's now a single hwloc__insert_object_by_cpuset() function
with root+reason (reason is mandatory) instead of one with
root+callback and one without.

The plugin ABI is bumped to 7.

insert_object_by_parent() doesn't get a "reason" argument
because it currently cannot fail. Hopefully we won't have
to change the plugin ABI because of this anytime soon.

Signed-off-by: Valentin Hoyet <valentin.hoyet@inria.fr>
Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedhwloc/topology-hpux.c (diff)
The file was modifiedinclude/hwloc.h (diff)
The file was modifiedhwloc/topology-darwin.c (diff)
The file was modifiedhwloc/topology-bgq.c (diff)
The file was modifiedhwloc/distances.c (diff)
The file was modifiedhwloc/topology-linux.c (diff)
The file was modifiedhwloc/topology.c (diff)
The file was modifiedhwloc/topology-windows.c (diff)
The file was modifiedinclude/hwloc/rename.h (diff)
The file was modifiedhwloc/topology-synthetic.c (diff)
The file was modifiedinclude/private/private.h (diff)
The file was modifiedhwloc/topology-hardwired.c (diff)
The file was modifiedhwloc/topology-freebsd.c (diff)
The file was modifiedinclude/hwloc/plugins.h (diff)
The file was modifiedhwloc/topology-aix.c (diff)
The file was modifiedhwloc/topology-x86.c (diff)
The file was modifiedhwloc/topology-solaris.c (diff)