SuccessChanges

Summary

  1. linux: factorize some fd/path reading functions back (details)
  2. linux: rework read_path_by_length() return value (details)
  3. linux: use helpers for reading tid location (details)
  4. linux: use helpers for reading nvidia gpu numa nodes (details)
  5. linux: use helpers for reading os device numa node (details)
  6. linux: use helpers for reading the pci config space (details)
  7. tests/diff: fix the test when the first NUMA node is CPU less (details)
Commit 4c2e69957227369647c063ad39460fc143089f64 by brice.goglin
linux: factorize some fd/path reading functions back

There's no strong need to have read_fd_as_cpumask/list()
separated from read_path_as_cpumask/list(), merge them back.

Also it avoids using open() in some cases (no fsroot) and
hwloc_open() in others (fsroot).

Also it will simplify support for readfile() (if it ever gets merged)
since we now open/read/close in the same function, but there's still
some work to do for reading cpumask/cpulist with readfile().

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedhwloc/topology-linux.c (diff)
Commit 17b2bface82f75fc785c666123a53988c2f564c2 by brice.goglin
linux: rework read_path_by_length() return value

Return the length read instead of success/failure.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedhwloc/topology-linux.c (diff)
Commit 78567719c0c92f13fbe3dbc719a3f9e14041f619 by brice.goglin
linux: use helpers for reading tid location

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedhwloc/topology-linux.c (diff)
Commit c407d430e58a4c8a78778a7688c56835e2b7503f by brice.goglin
linux: use helpers for reading nvidia gpu numa nodes

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedhwloc/topology-linux.c (diff)
Commit 547de8d88a8a2b06ca40a75c7ea3a2318cb0c22b by brice.goglin
linux: use helpers for reading os device numa node

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedhwloc/topology-linux.c (diff)
Commit 01a23ab551c22b6871e3f2cf2d36bf2b0ad168e1 by brice.goglin
linux: use helpers for reading the pci config space

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedhwloc/topology-linux.c (diff)
Commit 806a8c2a8eeea73c8a18d1a4da265a6c9e5ae247 by brice.goglin
tests/diff: fix the test when the first NUMA node is CPU less

NUMA differences may actually appear before PU differences if
the first NUMA node is CPU less.
Handle both orders in the assertions.

Thanks to James D. Trotter for reporting the issue.
Closes #374.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedtests/hwloc/hwloc_topology_diff.c (diff)