[Jenkins]Jenkins

SuccessChanges

Summary

  1. API: the non-printable character warning applies to info key names too (details)
  2. doc: clarify how we talk about info attributes (details)
  3. doxy: add missing comma (details)
  4. API: add hwloc_infos_s structure in objects (details)
  5. core: switch internal functions to use hwloc_infos_s structure (details)
  6. API: add hwloc_get_info_by_name() (details)
  7. cpukind: switch to struct hwloc_infos_s in the API (details)
  8. core: add an "allocated" private field in struct hwloc_infos_s (details)
  9. API: make it clear that add_info() wants non-NULL name+value (details)
  10. API: add hwloc_modify_infos() to add/replace/remove info attrs (details)
  11. tests: rename and enlarge the infos test (details)
  12. core: use the new internal hwloc__replace_infos() and remove add_info_nodup() (details)
  13. utils/annotate: abstract-out info attr operations (details)
  14. utils/annotate: reimplement info operations using hwloc_modify_infos() (details)
  15. utils/annotate: add the "cpukind#N" fake location to tweak cpukind infos (details)
  16. tests/{cuda*,nvml,opencl,levelzero,rsmi,gl}: fix Backend info attr check (details)
  17. utils/annotate.1: remove a spurious '+' (details)
Commit 8285b0612e29f562b8e03843190e6816c1195da6 by brice.goglin
API: the non-printable character warning applies to info key names too

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedinclude/hwloc.h (diff)
Commit 7ba5dc5ca7a235155ec155a7e99b27db856a22bf by brice.goglin
doc: clarify how we talk about info attributes

Uniformize and clarifies things.
Use "name" instead of "key".
Use "pair" when appropriate.
Misc.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedutils/hwloc/hwloc-calc.1in (diff)
The file was modifieddoc/hwloc.doxy (diff)
The file was modifiedinclude/hwloc.h (diff)
Commit 37b590b8e3a1a0a65d912a5b20c836c3bc4cfc56 by brice.goglin
doxy: add missing comma

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifieddoc/hwloc.doxy (diff)
Commit d7a40a4ae52d42b5b665bc618b18fc597be108f5 by brice.goglin
API: add hwloc_infos_s structure in objects

It contains the existing hwloc_info_s array and its length.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedtests/hwloc/gl.c (diff)
The file was modifiedhwloc/diff.c (diff)
The file was modifiedtests/hwloc/opencl.c (diff)
The file was modifiedtests/hwloc/levelzero.c (diff)
The file was modifiedutils/lstopo/lstopo-draw.c (diff)
The file was modifiedhwloc/topology-linux.c (diff)
The file was modifiedhwloc/topology.c (diff)
The file was modifiedhwloc/topology-xml.c (diff)
The file was modifiedhwloc/traversal.c (diff)
The file was modifiedNEWS (diff)
The file was modifiedinclude/hwloc/inlines.h (diff)
The file was modifiedtests/hwloc/cuda.c (diff)
The file was modifiedinclude/hwloc.h (diff)
The file was modifiedtests/hwloc/nvml.c (diff)
The file was modifiedinclude/hwloc/rename.h (diff)
The file was modifiedtests/hwloc/cudart.c (diff)
The file was modifiedutils/hwloc/hwloc-info.c (diff)
The file was modifiedutils/hwloc/hwloc-annotate.c (diff)
The file was modifiedhwloc/topology-x86.c (diff)
The file was modifiedtests/hwloc/rsmi.c (diff)
Commit 6e41289b44f0e34ad11ac29767e0163ec3d7b3cc by brice.goglin
core: switch internal functions to use hwloc_infos_s structure

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedhwloc/topology-x86.c (diff)
The file was modifiedhwloc/topology.c (diff)
The file was modifiedhwloc/diff.c (diff)
The file was modifiedhwloc/topology-darwin.c (diff)
The file was modifiedhwloc/topology-xml.c (diff)
The file was modifiedhwloc/cpukinds.c (diff)
The file was modifiedinclude/private/private.h (diff)
The file was modifiedhwloc/topology-linux.c (diff)
The file was modifiedhwloc/topology-windows.c (diff)
Commit 060604cb3ee924a51731756221cefafdcef97ea4 by brice.goglin
API: add hwloc_get_info_by_name()

It takes a struct hwloc_infos_s
(while hwloc_obj_get_info_by_name() takes an object).

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedinclude/hwloc/rename.h (diff)
The file was modifieddoc/Makefile.am (diff)
The file was modifiedinclude/hwloc/inlines.h (diff)
The file was modifiedinclude/hwloc.h (diff)
Commit 669a1c0fc547076fc656fc3e92be90f52a93e629 by brice.goglin
cpukind: switch to struct hwloc_infos_s in the API

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedutils/lstopo/lstopo.c (diff)
The file was modifiedinclude/hwloc/cpukinds.h (diff)
The file was modifiedutils/lstopo/lstopo-text.c (diff)
The file was modifiedNEWS (diff)
The file was modifiedhwloc/cpukinds.c (diff)
The file was modifiedtests/hwloc/cpukinds.c (diff)
The file was modifiedutils/hwloc/hwloc-annotate.c (diff)
The file was modifiedutils/hwloc/hwloc-calc.c (diff)
The file was modifiedutils/hwloc/hwloc-info.c (diff)
Commit 56386ebec74b0647fe51b860b930a3c53e90e4a4 by brice.goglin
core: add an "allocated" private field in struct hwloc_infos_s

To properly preallocate the array when adding elements.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedhwloc/topology-linux.c (diff)
The file was modifiedinclude/hwloc.h (diff)
The file was modifiedhwloc/topology-x86.c (diff)
The file was modifiedhwloc/topology.c (diff)
The file was modifiedutils/hwloc/hwloc-annotate.c (diff)
The file was modifiedhwloc/topology-darwin.c (diff)
The file was modifiedtests/hwloc/cpukinds.c (diff)
The file was modifiedhwloc/topology-xml.c (diff)
Commit 293206f827f2f812a8bcf75d23afbf1ebdf8c23e by brice.goglin
API: make it clear that add_info() wants non-NULL name+value

It'd crash otherwise.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedinclude/hwloc.h (diff)
The file was modifiedhwloc/topology.c (diff)
Commit 6095a743d52d05bbda6f11b1fd7633e49e873915 by brice.goglin
API: add hwloc_modify_infos() to add/replace/remove info attrs

hwloc_obj_add_info() is now implemented on top of it.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifieddoc/Makefile.am (diff)
The file was modifiedinclude/hwloc/rename.h (diff)
The file was modifiedhwloc/topology.c (diff)
The file was modifiedNEWS (diff)
The file was modifieddoc/hwloc.doxy (diff)
The file was modifiedinclude/hwloc/inlines.h (diff)
The file was modifiedinclude/hwloc.h (diff)
Commit 5cb289dc83f353d9cc6516f597884fa37e892d3c by brice.goglin
tests: rename and enlarge the infos test

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedtests/hwloc/CMakeLists.txt (diff)
The file was addedtests/hwloc/infos.c
The file was modifiedtests/hwloc/Makefile.am (diff)
The file was removedtests/hwloc/hwloc_obj_infos.c
Commit a03b7f3fd04fe052d3fe256d78a92427fbe89557 by brice.goglin
core: use the new internal hwloc__replace_infos() and remove add_info_nodup()

And clarify that callers may always call replace,
even if the info doesn't exist yet.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedinclude/private/private.h (diff)
The file was modifiedinclude/hwloc/rename.h (diff)
The file was modifiedhwloc/topology-x86.c (diff)
The file was modifiedhwloc/topology-linux.c (diff)
The file was modifiedhwloc/topology.c (diff)
Commit 749e22a91dcc5d9875f8099ca256d958cb03e020 by brice.goglin
utils/annotate: abstract-out info attr operations

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedutils/hwloc/hwloc-annotate.c (diff)
Commit d07e4ac7ff8e51bf47918f9b9bf48ee2b248c6dd by brice.goglin
utils/annotate: reimplement info operations using hwloc_modify_infos()

It was relying on non-official/non-documentation manual changes to the info attr arrays.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedutils/hwloc/hwloc-annotate.c (diff)
Commit 6acac769c3f30c677dbc979d35515fa6265316e8 by brice.goglin
utils/annotate: add the "cpukind#N" fake location to tweak cpukind infos

And document that we may also call hwloc-annotate multiple times
with same cpukind parameters but different info names and values.

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedutils/hwloc/test-hwloc-annotate.sh.in (diff)
The file was modifiedutils/hwloc/hwloc-annotate.1in (diff)
The file was modifiedutils/hwloc/hwloc-annotate.c (diff)
The file was modifiedutils/hwloc/test-hwloc-annotate.output (diff)
Commit 40c953d943dd2ac1a778b89cd678ab14f9559aaa by brice.goglin
tests/{cuda*,nvml,opencl,levelzero,rsmi,gl}: fix Backend info attr check

Broken in 74e32c185f326f908c1e3ad3e8b2e9ad76ef4785

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedtests/hwloc/levelzero.c (diff)
The file was modifiedtests/hwloc/rsmi.c (diff)
The file was modifiedtests/hwloc/opencl.c (diff)
The file was modifiedtests/hwloc/cuda.c (diff)
The file was modifiedtests/hwloc/gl.c (diff)
The file was modifiedtests/hwloc/nvml.c (diff)
The file was modifiedtests/hwloc/cudart.c (diff)
Commit 82c0e0af9eb565270728841fa4665d10c0bed786 by brice.goglin
utils/annotate.1: remove a spurious '+'

Forgotten in 6acac769c3f30c677dbc979d35515fa6265316e8

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
The file was modifiedutils/hwloc/hwloc-annotate.1in (diff)